Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1585237pxb; Thu, 4 Feb 2021 17:40:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwgc7pEgnEIRbBEhfgL57ZsgQHqGMkYalpGYSV3xT8iHg4UuGRCWhgdAZx5DmtSrFxVTHFQ X-Received: by 2002:a17:906:8410:: with SMTP id n16mr1794541ejx.551.1612489222568; Thu, 04 Feb 2021 17:40:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612489222; cv=none; d=google.com; s=arc-20160816; b=o2VAsH7x08j0cch06EhgspATLYxoNwqgNHOmfEvgy9z6X8nkugcYObtpUOEI5WWdbe 6NVkHvA6LK6DjT8N5tmvCqx8mzF1ZYklvj46G7ZXSL/SgPgDwxWMZq8RWp61tsYBVhiy O78MPQP4Cjkibr3u+j1MS6CdQ+w++aoLBurBeIFVSFMrdtKJSAsN1mYoLl+FvrD0ObcY sBgBV9pf9CeItGd65YUBqVCyLPFWh6Ooh1qnPUEaUU/PpmOxIK+CKQKk7KQ/KvWTbdAU pi6gaeDNqpwJZqG1MVozh8+LIdTVlVpa/vYva6u11M5CfdF3LR+4/2wS9Ci/2K288bwJ I2CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=gpuC+d2FUOI/ZHg93wQH+r85JDI4pp/FX9Ub2W2auJA=; b=HJiLf/zBOcOqN/9kQuUAPt4idPYFyEzhVDYBjqplLEx1EIiDJQMLBhEAfyhUkXXqE+ C8tqZeA4+a7dDJ1tuXZPehpIJfpcVAqdDxysaE0DTyGlX5Yb+rXnA37v7oGAoRnGWGty TgafXnUamR96LHUlGXt9sUiXQdAehXu15zC5vD/qIWGKxmSPpOd6qWrdg6cX0e+zK4mX pyKg2rLyhsFatwsh/c1tyOt6Enmkp7gBYgFnqSI5JQypzSzARMRap8PbsYGkDcyrRq/i rozVExY03fnG9yngtGwsO4Dn5KEiZIXZTyUpg5APU9I1YigTdkEniUgtKsYsAUxSS2cI iBzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="IeotN/9b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gx6si3423185ejc.508.2021.02.04.17.39.58; Thu, 04 Feb 2021 17:40:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="IeotN/9b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239787AbhBDTUF (ORCPT + 99 others); Thu, 4 Feb 2021 14:20:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238713AbhBDTTi (ORCPT ); Thu, 4 Feb 2021 14:19:38 -0500 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B9D3C06178C for ; Thu, 4 Feb 2021 11:18:56 -0800 (PST) Received: by mail-pj1-x102e.google.com with SMTP id g15so2390946pjd.2 for ; Thu, 04 Feb 2021 11:18:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gpuC+d2FUOI/ZHg93wQH+r85JDI4pp/FX9Ub2W2auJA=; b=IeotN/9b8v5XKf4EhKYsx0kfJDGFixxFAbgIG7uuE5tnabLRIRh0tUk3+MzaseOpkO MGOfJLn/t0mNBWKilsOO0R1ZgJ6TjREJeV04mMuqVPU0OoeZfGS3dqy0VbE+EvvmXJgg ra34agXgJ5zd5/OLk3jfRChhcNS4ABtu9mHgG8ARfKSTgC/4vLvvrSay2qoLL3Gzr3Dd HAdmCEbXZErEAO0aPLwRJ+qLYZN2w7HXPO6aKm0qC4+1SK+wu7rNYvqDwzUbY9GsiJ51 NPYomZ2yLP+eL9f0GUvcJMzbF+QnmE0YujcWl0QGEnpL1s/uI3nJkw08iQvzzN3jBl/q xS8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gpuC+d2FUOI/ZHg93wQH+r85JDI4pp/FX9Ub2W2auJA=; b=S4meZMErvYMHHhIMCpYS567SXOJtatc0nmzEZkb/+fJxJ4PEMnidhnBs0GMFEX9Nat kE7oSopDWqUGcgkk51j4R4CqqdYqmyGviML8b98gM6XKhzPJVl0vqE9QFx3jvZlKFy4f clsWe9fg3DZGLRmJ4Vq2XlXurtd25n+hk8T9dP8XHX28lYl4d6Px9iCEmfjktagGyYKo X5aluJZOs9GGQM+xEwh0kPo5ImxFgZArWzxo1js3QFEZm7cL5+xfpcCUwcOvWq+ACxZW ib2VJ41QHw1H2MqPi856RUOjOphDkNsBHHZ4053crEpnoTjeBGiN2tjRlqhjTjG5Ye/s 8mHQ== X-Gm-Message-State: AOAM532KF1+UvICZg8ZHIbzPTPn9SZNnClYrFmrMBiFCW7MO3u1RlFVk 08oQgWMi+iuO200fc6XpmJN5QyDRufkWpRFqAkcpBg== X-Received: by 2002:a17:90a:bf10:: with SMTP id c16mr435444pjs.101.1612466335618; Thu, 04 Feb 2021 11:18:55 -0800 (PST) MIME-Version: 1.0 References: <20210130004401.2528717-1-ndesaulniers@google.com> <20210130004401.2528717-2-ndesaulniers@google.com> <20210204103946.GA14802@wildebeest.org> In-Reply-To: <20210204103946.GA14802@wildebeest.org> From: Nick Desaulniers Date: Thu, 4 Feb 2021 11:18:44 -0800 Message-ID: Subject: Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice To: Mark Wielaard Cc: Masahiro Yamada , Nathan Chancellor , Andrew Morton , Sedat Dilek , LKML , clang-built-linux , Linux Kbuild mailing list , linux-arch , Jakub Jelinek , Fangrui Song , Caroline Tice , Nick Clifton , Yonghong Song , Jiri Olsa , Andrii Nakryiko , Arnaldo Carvalho de Melo , Arvind Sankar , Nathan Chancellor Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 4, 2021 at 2:41 AM Mark Wielaard wrote: > > Hi Nick, > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > the default. Does so in a way that's forward compatible with existing > > configs, and makes adding future versions more straightforward. > > > > GCC since ~4.8 has defaulted to this DWARF version implicitly. > > And since GCC 11 it defaults to DWARF version 5. > > It would be better to set the default to the DWARF version that the > compiler generates. So if the user doesn't select any version then it > should default to just -g (or -gdwarf). I disagree. https://lore.kernel.org/lkml/CAKwvOdk0zxewEOaFuqK0aSMz3vKNzDOgmez=-Dae4+bodsSg5w@mail.gmail.com/ """ I agree that this patch takes away the compiler vendor's choice as to what the implicit default choice is for dwarf version for the kernel. (We, the Linux kernel, do so already for implicit default -std=gnuc* as well). ... But I'm going to suggest we follow the Zen of Python: explicit is better than implicit. """ We have a number of in tree and out of tree DWARF consumers that aren't ready for DWARF v5. Kernel developers need a way to disable DWARF v5 until their dependencies are deployed or more widely available. I'm happy to consider eventually moving the default DWARF version for the kernel to v5, and ideas for how to wean developers off of v4, but I don't think forcing v5 on kernel developers right now is the most delicate approach. -- Thanks, ~Nick Desaulniers