Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1588417pxb; Thu, 4 Feb 2021 17:46:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJyW3WIxN4eiNzYnGLHFKSwxpQCF6m8T+cVVJN+b0FjRu1xoD2YiBkYkMUgGoRj4OpMBZRK6 X-Received: by 2002:a17:906:2bc2:: with SMTP id n2mr1736640ejg.381.1612489614629; Thu, 04 Feb 2021 17:46:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612489614; cv=none; d=google.com; s=arc-20160816; b=1BGQFkI02nDNnNgXDVwmqgFUN+OAq+lqsyOkf+RsV8qse2z5cLj5/oPHmweS/54Ggw LbuauaVh7CMTSuS7SkgRLDgDhoXhKgr5D3sxvnQMzhYDbYtlE517UynTdD4g+4bt81GZ RMTWHWXQpFlH1dh5Z5rVfxSSnrwu8xlvej7sYdEKTHbOJ5hd8EZcHshkbQ65r2JhMBUa 9LdaVz9G5JHdtXpOwbQcb6VYqQ134zoirFszxm0G4vNRs5yTxWOziatDvM6ouz63WXPE Pj9mvMEDvcgAyuqa/BYmNHV0W2NunS/G8X5/FdrdEKIOSNwmXDcXuA+3FlxzAm0E1c95 7qvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=NozwlRAG2ePHc4pUyYoCPsFl/Utzo0HDLUhQTIsRhAc=; b=kZgRa2QFPu3LSTX/yVAbpMo9OOMrihkW8JVhXWXfkt5HKAZQ1wUriqkg5whkSp/Inu 0LkaUIyK/UG6wz9P+B5M2MOntpMv61CQklTxWewv6P+dnnXOz0aopqtGzQ+q2Z0QxtRQ AXXEdfyHZjxMbQY2l+8UB5LFp2P5LAlg2o2Yn2oQ9p0E7W8dr5DoQA50EwaCfM0Dr0Vn krluT3AqaF2HOD+8A8TIsQCsLhm8ySAVFYqcvXIeOXKujItqSULyQQo6j9tllSix0BRf zKP6NuE0yoNtt61rgIIvekln5xTo9t9Py9c50VXmfVJhYUU86pN6nt0q48YrQoIBEaI1 LinQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi18si4214448ejb.369.2021.02.04.17.46.30; Thu, 04 Feb 2021 17:46:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239873AbhBDT6j (ORCPT + 99 others); Thu, 4 Feb 2021 14:58:39 -0500 Received: from mga04.intel.com ([192.55.52.120]:64649 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239524AbhBDTxD (ORCPT ); Thu, 4 Feb 2021 14:53:03 -0500 IronPort-SDR: xhiiU7J+LIIjyYXnAcV9002zpXaQ0xrGz7DoMSL1awV70dg5EVcC2OCzDhkj/ZjPgymdqnoAG4 KI1OTR5oLJ+g== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="178755296" X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="178755296" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 11:52:21 -0800 IronPort-SDR: lk2OeIHmNPWbmvRojJjqR8Xtfh20RG7xmOB4Z1oM64zOBayunz7AhdCrNPMsooc6EW9bI/cxGe DT69vT3vA40Q== X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="434088875" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.212.188.246]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 11:52:20 -0800 Date: Thu, 4 Feb 2021 11:52:20 -0800 From: Jesse Brandeburg To: Alexander Lobakin Cc: "David S. Miller" , Jakub Kicinski , John Hubbard , David Rientjes , Yisen Zhuang , Salil Mehta , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RESEND v3 net-next 4/5] net: use the new dev_page_is_reusable() instead of private versions Message-ID: <20210204115220.0000018d@intel.com> In-Reply-To: <20210202133030.5760-5-alobakin@pm.me> References: <20210202133030.5760-1-alobakin@pm.me> <20210202133030.5760-5-alobakin@pm.me> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexander Lobakin wrote: > Now we can remove a bunch of identical functions from the drivers and > make them use common dev_page_is_reusable(). All {,un}likely() checks > are omitted since it's already present in this helper. > Also update some comments near the call sites. > > Suggested-by: David Rientjes > Suggested-by: Jakub Kicinski > Cc: John Hubbard > Signed-off-by: Alexander Lobakin I don't know why it was missed in the series update, but: Reviewed-by: Jesse Brandeburg