Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210204225652.1707066-1-saravanak@google.com>
In-Reply-To: <20210204225652.1707066-1-saravanak@google.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 4 Feb 2021 21:39:34 -0300
Message-ID: <CAOMZO5C=pkBtaEL6sSLx9rDxXHzrzC-qwfAUBaQEcoaG8TxnGw@mail.gmail.com>
Subject: Re: [PATCH v2] ARM: imx: avic: Convert to using IRQCHIP_DECLARE
To:     Saravana Kannan <saravanak@google.com>
Cc:     Russell King <linux@armlinux.org.uk>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Martin Kaiser <martin@kaiser.cx>, kernel-team@android.com,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Saravana,

On Thu, Feb 4, 2021 at 7:56 PM Saravana Kannan <saravanak@google.com> wrote:
>
> Remove a lot of boilerplate code. Also address boot issues on imx25 with
> fw_devlink=on that were reported by Martin.

The commit message could be improved.

It starts like it was just a clean-up and then it says it fixes a boot
issue on imx25.

Please explain why converting IRQCHIP_DECLARE fixes the boot issue.