Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1635967pxb; Thu, 4 Feb 2021 19:27:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJwcWM27KbvV2fal9HhAsVLohpkjz5C2TmAR/i/eSAGJnOS2b/Bwl223S5WvQIXBXHBDYMJ6 X-Received: by 2002:a05:6402:31ae:: with SMTP id dj14mr1616619edb.364.1612495637198; Thu, 04 Feb 2021 19:27:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612495637; cv=none; d=google.com; s=arc-20160816; b=cdF0Jp/vxwN6AK0KrYskOJu125nZP/jh36HM0VRl4aC1Zdr3G7YzJ69MTU9YGRSEJE 4MGstfioWXRNiDLwiZU3R2tnx3ktHzYMZG6Ta2uk3kv64p4g8bquczZGJ/qnPf1eC569 8Qa0nnbaA8ZTZS+kl4TebW5CboiDJXfjP6tdnznIw2bfh8MSMOdEntay2zJb+FplGVfa /GDTrXNtCONUBIl2k9/iwxWmF9TBqa/cjYeSXh8mnZmmHvKoOc8sp+qkDuhZAkdRwhMG gU+/VD3ZJ6hWf80q6kEYJ0fihXkLy7Flzi19sE2p4YBb6w8nPAiGyCV6wWt0/uPHZNNl WNgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=cYGMAdaRz8G1QUdS9+LomG6wtHz0qQi99/eTTuMLV+0=; b=mV1BvNVC4gwK0ZpDJjSdrWUvLQcT4TU1dap1a1/mrLaB4/xSvN35d5pgsO4kwAxY4z le+4TXcAF8c15iF454Z5yvmYgKkMEW+xVdN+2payn6F49iLBpXTUqXyeRAL450hcJqTn v7cRuE0s1l/w/V8m/dayZOZAjth1Dg8lOCU5u79l+ACoN0izqymow5E4rEBRpplYETEO J+v/fM9K8V3jNx1wyk/koyswROWaALwXpKprJHM8GomyT2sF9k6g4GFcijw4vDHoOtIQ Tp6UncQtF4pLmQFnf1W4mQMgb5drRPzc0mDx1OzB4EI3GaJDmfJAsa+ffWZUDJA//+w5 AZLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hs28si4607726ejc.141.2021.02.04.19.26.52; Thu, 04 Feb 2021 19:27:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbhBEDXp (ORCPT + 99 others); Thu, 4 Feb 2021 22:23:45 -0500 Received: from mail-lf1-f42.google.com ([209.85.167.42]:41463 "EHLO mail-lf1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbhBEDXl (ORCPT ); Thu, 4 Feb 2021 22:23:41 -0500 Received: by mail-lf1-f42.google.com with SMTP id a8so7820882lfi.8; Thu, 04 Feb 2021 19:23:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cYGMAdaRz8G1QUdS9+LomG6wtHz0qQi99/eTTuMLV+0=; b=WNGuQmEeSDk6Q8ZsHzFiFkYrL/hrbbtM7HwWDK9ip2uhlK8b4qRdlW5Ea1Lr/4yF71 5Mtoj1kCeOvUXETveEuLNLdsp289LaSD17tiRpEEFZmIc0JhyAh49ST2trV2vC0Pfpgd 3oqaMzu+Flo4xBy/iHX6NaaPxVvrliwa4jmDfikh+H4MFjj3IZqigToQmvlj/BMfPNkj 3subI6/QjV4VlYIv4n3hJ+3Xz96tHg6kq2CIZf5GD3uHhMz+TuYHCBFK9PN13JRtcABW eZhdqUBC0db2CETvMY6P4xFL4ou30gJFgqmYkfehjxeE1F6EFvIsSFi5KS5sx3P30REp TgZQ== X-Gm-Message-State: AOAM531wflf2ddEIwzVtaXwDAdbwFYsuawn9SiFFRD9rq+KeKSOs6KwD 7BmCjVX+KvoXAgYfcuYs/0ofl8G9flh8cg== X-Received: by 2002:ac2:5f6a:: with SMTP id c10mr1311524lfc.216.1612495380162; Thu, 04 Feb 2021 19:23:00 -0800 (PST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id e10sm830732lfs.304.2021.02.04.19.23.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Feb 2021 19:23:00 -0800 (PST) Received: by mail-lf1-f54.google.com with SMTP id i187so7841687lfd.4; Thu, 04 Feb 2021 19:23:00 -0800 (PST) X-Received: by 2002:ac2:5f56:: with SMTP id 22mr1458557lfz.296.1612495374946; Thu, 04 Feb 2021 19:22:54 -0800 (PST) MIME-Version: 1.0 References: <20210204184710.1880895-1-jernej.skrabec@siol.net> <20210204184710.1880895-4-jernej.skrabec@siol.net> In-Reply-To: <20210204184710.1880895-4-jernej.skrabec@siol.net> From: Chen-Yu Tsai Date: Fri, 5 Feb 2021 11:22:44 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/5] drm/sun4i: dw-hdmi: always set clock rate To: Jernej Skrabec Cc: Maxime Ripard , Mike Turquette , Stephen Boyd , David Airlie , Daniel Vetter , linux-clk , linux-arm-kernel , linux-kernel , dri-devel , linux-sunxi , Andre Heider Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 5, 2021 at 2:48 AM Jernej Skrabec wrote: > > As expected, HDMI controller clock should always match pixel clock. In > the past, changing HDMI controller rate would seemingly worsen > situation. However, that was the result of other bugs which are now > fixed. > > Fix that by removing set_rate quirk and always set clock rate. > > Fixes: 40bb9d3147b2 ("drm/sun4i: Add support for H6 DW HDMI controller") > Tested-by: Andre Heider > Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai