Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Feb 2021 19:30:30 -0800
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>, linux-xfs@vger.kernel.org,
        Linux Next <linux-next@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Brian Foster <bfoster@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        Allison Henderson <allison.henderson@oracle.com>
Subject: Re: [PATCH] xfs: fix unused variable build warning in xfs_log.c
Message-ID: <20210205033030.GL7193@magnolia>
References: <20210205031814.414649-1-jhubbard@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210205031814.414649-1-jhubbard@nvidia.com>
Precedence: bulk

On Thu, Feb 04, 2021 at 07:18:14PM -0800, John Hubbard wrote:
> Delete the unused "log" variable in xfs_log_cover().
> 
> Fixes: 303591a0a9473 ("xfs: cover the log during log quiesce")
> Cc: Brian Foster <bfoster@redhat.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Darrick J. Wong <djwong@kernel.org>
> Cc: Allison Henderson <allison.henderson@oracle.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> Hi,
> 
> I just ran into this on today's linux-next, so here you go!

Thanks for the tipoff, I just realized with horror that I got the git
push wrong and never actually updated xfs-linux.git#for-next.  This (and
all the other gcc warnings) are fixed in "xfs-for-next" which ... is not
for-next.

Sigh.....  so much for trying to get things in for testing. :(

--D

> 
> thanks,
> John Hubbard
> NVIDIA
> 
>  fs/xfs/xfs_log.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 58699881c100..5a9cca3f7cbf 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1108,7 +1108,6 @@ static int
>  xfs_log_cover(
>  	struct xfs_mount	*mp)
>  {
> -	struct xlog		*log = mp->m_log;
>  	int			error = 0;
>  	bool			need_covered;
>  
> 
> base-commit: 0e2c50f40b7ffb73a039157f7c38495c6d99e86f
> -- 
> 2.30.0
>