Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1647039pxb;
        Thu, 4 Feb 2021 19:52:42 -0800 (PST)
X-Google-Smtp-Source: ABdhPJz4ruF3zKIfZlYQVti4iu8pRiIWof7OnmkRMEqqw7H/Q9ZYZMLmiUlrz2qHf+AXnYAJDCXX
X-Received: by 2002:aa7:c80a:: with SMTP id a10mr1653770edt.141.1612497162514;
        Thu, 04 Feb 2021 19:52:42 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1612497162; cv=none;
        d=google.com; s=arc-20160816;
        b=QdR4kx4fmbwcxal5EjPJZHCHtISE81KeEvfMKGXSHur1qZaDNp/4cKz83BWQ2r5sYu
         Xik6A71sUuRTaAOFqjXaf6mPxjgrLdOg94uAAzkj4Rp1m/sJ/aRPcdau+CI/nbqIw9s9
         Rh6gdMLNpopKp5ht3+IDFXBSa2wXaXBP1aoSA9ri844viylJKudLkN1gEsIwxW6QAASP
         Ad7oDvx/QUp0dCkZgsIUX0aYxxnC2KpxcMMcfWfCykstPiyC48+wpNPymf32Ep0wMqr4
         MREdC7woV7jMIIlw0kylAsdytALFnKcLFORodXuYbZfXZ+hLok2chiICQme3i43+0jnb
         HxJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=aVWP6jGi6yMses/G7c+2YFcawvLkfOUygGY3+F5TXgI=;
        b=YJVeQIHAT4ctKNFVp8VYTInIYkX4N29QTUKW1fA++dSl/3pMk+RkqaKKPUybpX928v
         POg3TrWpZuubkskYYjctlqT2jFBlb7wtZi7I9e1oif0RgBL8Z81g35+qQ4YFMPjdnAbP
         IxNLq+jFk/ZTOMka1HISoq1bBGmyqGeQvS1nnC0cQKGn8GYxZQuAoDv5DRS6tGGUdExM
         GcppnSTm0dByO5k5cpeEeZHX+V/h6YmYriXTayhOaFVQWpdvwJhyFqTtOG1BH4xw0KCq
         3s4Wf44uCHZS50X1LfqghRDsjTYF/6jqvdRYUqed5hG6zQBn7wBu6zGHBAh51KFNHpk+
         +igQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=KWALDuMd;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id l5si4332238ejd.408.2021.02.04.19.52.17;
        Thu, 04 Feb 2021 19:52:42 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=KWALDuMd;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230174AbhBEDuf (ORCPT <rfc822;lkml.email@gmail.com> + 99 others);
        Thu, 4 Feb 2021 22:50:35 -0500
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:2935 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229692AbhBEDuf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 4 Feb 2021 22:50:35 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B601cc0630000>; Thu, 04 Feb 2021 19:49:55 -0800
Received: from [10.2.60.31] (172.20.145.6) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 5 Feb
 2021 03:49:54 +0000
Subject: Re: [PATCH] xfs: fix unused variable build warning in xfs_log.c
To:     "Darrick J. Wong" <djwong@kernel.org>
CC:     Stephen Rothwell <sfr@canb.auug.org.au>,
        <linux-xfs@vger.kernel.org>,
        Linux Next <linux-next@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Brian Foster <bfoster@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        Allison Henderson <allison.henderson@oracle.com>
References: <20210205031814.414649-1-jhubbard@nvidia.com>
 <20210205033030.GL7193@magnolia>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <11a20ea7-3d58-d102-0fcb-6bc92cfc86d5@nvidia.com>
Date:   Thu, 4 Feb 2021 19:49:54 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101
 Thunderbird/85.0
MIME-Version: 1.0
In-Reply-To: <20210205033030.GL7193@magnolia>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.20.145.6]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1612496995; bh=aVWP6jGi6yMses/G7c+2YFcawvLkfOUygGY3+F5TXgI=;
        h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
         MIME-Version:In-Reply-To:Content-Type:Content-Language:
         Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
        b=KWALDuMdgil2trdKyD9hNMG7KVtlXqK7G8/mnFLVzxIKItIhlT1O+MkL5vdgysNFN
         ckLMZyqhjMzE7YL0ZZoafYWo735tZBdeikGUWfjtCf3uj1NdxVDi25+gn6BbWd+4EL
         3Ln0AoNV2yXLFAbT9LMsExozEX5IMb0LzVVrEb2TwBRFHfwugSI1YVsbtn3kBxhe6c
         pF3ltoZ0xeF4sBSgsjPdZpPX5QVzF7NTwaE0iTh3wrjqhVIRsZKwy9OCw55cfrCJq0
         e3tXUK6bslFVoN2Wh7dGMImquZSG/z6LX+Wev0r9x0CW7+M2USLkAdzqJvOMZJTreN
         5MO65EV4Ww7pw==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/4/21 7:30 PM, Darrick J. Wong wrote:
> On Thu, Feb 04, 2021 at 07:18:14PM -0800, John Hubbard wrote:
>> Delete the unused "log" variable in xfs_log_cover().
>>
>> Fixes: 303591a0a9473 ("xfs: cover the log during log quiesce")
>> Cc: Brian Foster <bfoster@redhat.com>
>> Cc: Christoph Hellwig <hch@lst.de>
>> Cc: Darrick J. Wong <djwong@kernel.org>
>> Cc: Allison Henderson <allison.henderson@oracle.com>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>> ---
>> Hi,
>>
>> I just ran into this on today's linux-next, so here you go!
> 
> Thanks for the tipoff, I just realized with horror that I got the git
> push wrong and never actually updated xfs-linux.git#for-next.  This (and
> all the other gcc warnings) are fixed in "xfs-for-next" which ... is not
> for-next.
> 
> Sigh.....  so much for trying to get things in for testing. :(
> 
Well, if it's any consolation, this is the *only* warning that fired during
my particular build, in linux-next. :)


thanks,
-- 
John Hubbard
NVIDIA