Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1674411pxb; Thu, 4 Feb 2021 20:57:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrYoilZUf7YazfkvyO0Eh88pTg2Y5TKj2tvlGZ59s+sqO9OO3wtL8gHf3MIeh+f1JX3Ode X-Received: by 2002:a17:906:70d4:: with SMTP id g20mr2369284ejk.361.1612501027744; Thu, 04 Feb 2021 20:57:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612501027; cv=none; d=google.com; s=arc-20160816; b=oSEiq4EdGyMVOr3qqCuSHW92Gytofmip+Y9KGgY2L7ShvIvP8uMuk0q16HO7alJ0JB DdyT0OkqHWHDer4EIoCSud2XA0Yp+3LEAKZm5EwjJvZq9KyxhiuX0E5Bo1mrNKLL0/zf m8PxKCyz9aGYhxYOcC9cZMmicNGSQkaMKLZHxVD37/qcZEzlqZh6S7wRm/IBzDxdtmYV +s0XPN9ESna3IeP8oVgr/utHwHcwCVxbJs8/a1iCJfGfB2rZarYggoVx4S1YEfzxTA82 81nEVl+2/ZWe0bIIFPu/qDlsQrD54l5BAlyfLrdAfrdF7czfbK+OaaSZHlRsfKQgZLEf gMjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9XDA8Fby0VxVTHCohOTyUITpcvTBN9KM25u4jqRVwPs=; b=SvOOHyZ1m3oJ6XgoTBVRoMXGaaGL4zf7b2PxHeett+Lg9j9YswJ7S5gOwXtG4Q47/2 uhW/25la68i2wL1b6Qb9jc3T4OZJBzfCY9f/Kzu4KgPW/xG8/0hgRxpoeCA/xqA1l6A/ WRqyt015imK9x5S8pHyA5jITiww9j0K0sSKPwmF8OMDaL9vvk7y5Xtwwc+zqp2PlmmDg mbyQi3zkPdY7Ko/wdAGPlDlSNGSFh+CDfPvPQ37I3+Xf3/qVV6eX3t6P7Prl5zCZqgQI 1GYdRK4IzQIY3A0UUFWO6B3HZg1C/piIOWWpdp80UigpHJJXrgmOTiJiKlG4ZSUEngLr dktw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D0rKaVDK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z6si2035620edr.441.2021.02.04.20.56.43; Thu, 04 Feb 2021 20:57:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D0rKaVDK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231169AbhBEExU (ORCPT + 99 others); Thu, 4 Feb 2021 23:53:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbhBEExI (ORCPT ); Thu, 4 Feb 2021 23:53:08 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABFF0C06178A; Thu, 4 Feb 2021 20:52:28 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id my11so6091691pjb.1; Thu, 04 Feb 2021 20:52:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9XDA8Fby0VxVTHCohOTyUITpcvTBN9KM25u4jqRVwPs=; b=D0rKaVDKeB2qxTlgxcKDSfVhy04m+Ci49FgsQnFVQaG3CGdaogLoeZj6AGb2yZ4cF4 RMg64n0wfuOXBee1+9wtE2BypjBRjH0LV0Z6aQXHeZRnhM74sicXYR+WBuH1reh3s9F0 2VOh12zCUr+0DlsrnXCKN3ui0OfJ9DpJaCEcwuMrcSS2ncaA1/k3oN9xxZ4hrumLlYXZ eeuY3BoOnc1OvcXj+kVqzOi68UzAqRzk2d4Et+EeoRRqsiPVCK03fyZ+FvdjAvh1WILK d8uV2DkWk8xF9erD3pAMbBPODx5hPdxXfyGumPPyxydUPprHNeBEhXErLbaBSyRMl/Na ns+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9XDA8Fby0VxVTHCohOTyUITpcvTBN9KM25u4jqRVwPs=; b=ED89DTkPJj3Gh0aJYtF5QXSQ3PGAj8cTdhDl83Swajcv9+8E8tnRdOuWBdKL/i6cT+ jzD1VZ4XSjkcPPN/143DMHWokQcKTzyQAnWaX2w6loHIbOVf3Q7nWDr5mdaKm5pRJ6ud enWS5ntQ7StFpmBeqd8hdUbfoXDdznqktGTIzM05x0s4TYVaXFf0FLAvyDNUPZg18hMy GlasHvImsHvu2cp9zwo5p63LrMdjRz4/rB721a4wt0KyYueT0/KmqAMv+Bpnn74u9vW+ x0OwFrY6RpmZJIV/5szGVOqc0BDAICDaGS3QBoEj9Nikps6CJdxy1rzyMjTgngViMKio WbRA== X-Gm-Message-State: AOAM533ryO4vWYrQ33CiM0oHLvdwXgoMtr9B6/UwZL7Q87IAq7i+FRaL V3AcUObQuzKsP1XGh8ABCUcZ2GC8lZcE8Q== X-Received: by 2002:a17:902:c40a:b029:e2:9a65:ffec with SMTP id k10-20020a170902c40ab02900e29a65ffecmr2655092plk.42.1612500748026; Thu, 04 Feb 2021 20:52:28 -0800 (PST) Received: from amypc-samantha.home ([47.145.126.51]) by smtp.gmail.com with ESMTPSA id s1sm6972440pjg.17.2021.02.04.20.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 20:52:27 -0800 (PST) From: Amy Parker To: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Amy Parker Subject: [PATCH 2/3] fs/efs: Correct spacing after C keywords Date: Thu, 4 Feb 2021 20:52:16 -0800 Message-Id: <20210205045217.552927-3-enbyamy@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205045217.552927-1-enbyamy@gmail.com> References: <20210205045217.552927-1-enbyamy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In EFS code, some C keywords (most commonly 'for') do not have spaces before their instructions, such as for() vs for (). The kernel style guide indicates that these should be of the latter variant. This patch updates them accordingly. Signed-off-by: Amy Parker --- fs/efs/inode.c | 8 ++++---- fs/efs/namei.c | 2 +- fs/efs/super.c | 10 +++++----- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/fs/efs/inode.c b/fs/efs/inode.c index 36d6c45046e2..2cc55d514421 100644 --- a/fs/efs/inode.c +++ b/fs/efs/inode.c @@ -130,7 +130,7 @@ struct inode *efs_iget(struct super_block *super, unsigned long ino) in->lastextent = 0; /* copy the extents contained within the inode to memory */ - for(i = 0; i < EFS_DIRECTEXTENTS; i++) { + for (i = 0; i < EFS_DIRECTEXTENTS; i++) { extent_copy(&(efs_inode->di_u.di_extents[i]), &(in->extents[i])); if (i < in->numextents && in->extents[i].cooked.ex_magic != 0) { pr_warn("extent %d has bad magic number in inode %lu\n", @@ -227,7 +227,7 @@ efs_block_t efs_map_block(struct inode *inode, efs_block_t block) { * check the stored extents in the inode * start with next extent and check forwards */ - for(dirext = 1; dirext < direxts; dirext++) { + for (dirext = 1; dirext < direxts; dirext++) { cur = (last + dirext) % in->numextents; if ((result = efs_extent_check(&in->extents[cur], block, sb))) { in->lastextent = cur; @@ -244,7 +244,7 @@ efs_block_t efs_map_block(struct inode *inode, efs_block_t block) { direxts = in->extents[0].cooked.ex_offset; indexts = in->numextents; - for(indext = 0; indext < indexts; indext++) { + for (indext = 0; indext < indexts; indext++) { cur = (last + indext) % indexts; /* @@ -255,7 +255,7 @@ efs_block_t efs_map_block(struct inode *inode, efs_block_t block) { * */ ibase = 0; - for(dirext = 0; cur < ibase && dirext < direxts; dirext++) { + for (dirext = 0; cur < ibase && dirext < direxts; dirext++) { ibase += in->extents[dirext].cooked.ex_length * (EFS_BLOCKSIZE / sizeof(efs_extent)); } diff --git a/fs/efs/namei.c b/fs/efs/namei.c index 38961ee1d1af..65d9c7f4d0c0 100644 --- a/fs/efs/namei.c +++ b/fs/efs/namei.c @@ -28,7 +28,7 @@ static efs_ino_t efs_find_entry(struct inode *inode, const char *name, int len) pr_warn("%s(): directory size not a multiple of EFS_DIRBSIZE\n", __func__); - for(block = 0; block < inode->i_blocks; block++) { + for (block = 0; block < inode->i_blocks; block++) { bh = sb_bread(inode->i_sb, efs_bmap(inode, block)); if (!bh) { diff --git a/fs/efs/super.c b/fs/efs/super.c index 874d82096b2f..dd97a071f971 100644 --- a/fs/efs/super.c +++ b/fs/efs/super.c @@ -169,7 +169,7 @@ static efs_block_t efs_validate_vh(struct volume_header *vh) { return 0; ui = ((__be32 *) (vh + 1)) - 1; - for(csum = 0; ui >= ((__be32 *) vh);) { + for (csum = 0; ui >= ((__be32 *) vh);) { cs = *ui--; csum += be32_to_cpu(cs); } @@ -181,11 +181,11 @@ static efs_block_t efs_validate_vh(struct volume_header *vh) { #ifdef DEBUG pr_debug("bf: \"%16s\"\n", vh->vh_bootfile); - for(i = 0; i < NVDIR; i++) { + for (i = 0; i < NVDIR; i++) { int j; char name[VDNAMESIZE+1]; - for(j = 0; j < VDNAMESIZE; j++) { + for (j = 0; j < VDNAMESIZE; j++) { name[j] = vh->vh_vd[i].vd_name[j]; } name[j] = (char) 0; @@ -198,9 +198,9 @@ static efs_block_t efs_validate_vh(struct volume_header *vh) { } #endif - for(i = 0; i < NPARTAB; i++) { + for (i = 0; i < NPARTAB; i++) { pt_type = (int) be32_to_cpu(vh->vh_pt[i].pt_type); - for(pt_entry = sgi_pt_types; pt_entry->pt_name; pt_entry++) { + for (pt_entry = sgi_pt_types; pt_entry->pt_name; pt_entry++) { if (pt_type == pt_entry->pt_type) break; } #ifdef DEBUG -- 2.29.2