Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1681899pxb; Thu, 4 Feb 2021 21:12:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzBF0yxyAfMFcIwWPiCTRfvmhvjfcN7lmpmSYCNqWUN3OPuWG8H592PqseucY7lEsVyn+4U X-Received: by 2002:a17:906:b09a:: with SMTP id x26mr2419189ejy.199.1612501979094; Thu, 04 Feb 2021 21:12:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612501979; cv=none; d=google.com; s=arc-20160816; b=I+ujfcfFxebUUuOqRK+HxWiSmoyk0AI9LLaWQXfNHO8VHQ+G4ytL36k3K3xURdVolU vmLQfQ6R+NOvGJYkzXJTV1FYQ+A0+5E8eCieDG88YUFohypcpG8edoq7fJ4crpnf1DUN omgRagpnXm674ZPXUq+7rawOl3ndrUpNTbjxC6mBaTjwDYnqHkZxplDdThiU72NMf5/K jGOAC8IW93BOvoMoQiEejS5wQOqRTzdj5onW7duiMDfUHsaJEnP1DDY83PuiG5qtW2ew 3VVYc+AevqBdAlyCMgnQBifwpOUjVhZ6cbTbhphDDk0eGd36l8bCSfHT7S1HSMYJGG1W o48g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=NaWh49c8oxKcT2X2WcLAcrnPi5K/hQ//X13GJh/Fz78=; b=tJ3gjcbkdVQ3NK+x+Szg0Wuafh/q116VnvQvxUPeeeiJf1VLwLMCq6iv1CQ8mqh5xY m9Q98vc8+VfuRCEwdk3d6KBlmHuYetx6ebBNQrxHX3DRmAKEqiRxM9MmMNrDmoSrA8KS yAtZ23o9i1JOJL4HVvsVTeaID2Q0J4IvWiplSX/w2KaZxfT+2r4pjVyBAr+zNTbcknFU 4gOBwpuce0SCKc1dKtJOHsyVdPOh7d2Rf1iERnZQ2SB4ljFA6XIgBGTlU5jBQXAwWloT TWy26dcGH/KHn0PSF9Yf5a0lt9YIHY4YPiQ3h6O4FwHjkEqxvmWV/qXJJxcF45BLiuUl q9lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NLvKyjM6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r15si4586547ejj.134.2021.02.04.21.12.34; Thu, 04 Feb 2021 21:12:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NLvKyjM6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230372AbhBEFK4 (ORCPT + 99 others); Fri, 5 Feb 2021 00:10:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:48008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230257AbhBEFKy (ORCPT ); Fri, 5 Feb 2021 00:10:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0D8BC64F4A; Fri, 5 Feb 2021 05:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612501813; bh=9c5QO5b6ZJnUlq5QqDrwRxOY/jSz1/k/4DWGc5PsGhw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NLvKyjM6mGshB0Ok38qEdnAlcgfKWyCsOkEBBS7kyGd+cN23b5dxtPMH7KsudxWjS JQv5c6Px+xhtK5fvLMcQZNBjrBSTnxftr3LM7kh6G5f+QXkfqGYYTE9MZzRM79a5V5 Mt/YMImWeCZqaTLQ3Tfv1e4X3WcFDhMMGXsrcw67a3X2OWZ9QCi2LRochx+869uT5S zWjJimWyoGaq5KkLwThoJZER8d9kRKJroKd0FcTyO4/Vqg5BpnWtTGiCYQPdAKx/9g yIyONLOch2VM+Bs/yehzLTy4yChN1RdqiIIHCxR89THgAjyY9go3zMYlQjcrtyqkfR tOLA6RJBf2YxQ== Date: Thu, 4 Feb 2021 21:10:12 -0800 From: Jakub Kicinski To: Vadym Kochan Cc: "David S. Miller" , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , netdev@vger.kernel.org, Mickey Rachamim , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/7] net: marvell: prestera: disable events interrupt while handling Message-ID: <20210204211012.48b044a0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210203165458.28717-3-vadym.kochan@plvision.eu> References: <20210203165458.28717-1-vadym.kochan@plvision.eu> <20210203165458.28717-3-vadym.kochan@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Feb 2021 18:54:53 +0200 Vadym Kochan wrote: > There are change in firmware which requires that receiver will > disable event interrupts before handling them and enable them > after finish with handling. Events still may come into the queue > but without receiver interruption. Sounds like you should do a major version bump for this. Old driver will not work correctly with new FW.