Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qnNaDrF8UB8RD7ZE6BLf1Rgftme2ELbStYCrQp/sllGShu67SIxdRZFbTSFzz8naTKSHbmzN5L
 6hzMHnQx5WQA==
IronPort-SDR: 5QfnJPgBPwLYURmVJG9624ZfaSoOmSNsiNY3rSMbMcI1YTUQkNSOc2mWz/cFGjTYTCMeLbDRby
 buv6rtcVoL/w==
Subject: Re: [PATCH 2/2] mmc: mmc_test: use erase_arg for mmc_erase command
To:     yann.gautier@foss.st.com, ulf.hansson@linaro.org
Cc:     linux@armlinux.org.uk, linus.walleij@linaro.org,
        ludovic.barre@foss.st.com, per.forlin@linaro.org,
        huyue2@yulong.com, wsa+renesas@sang-engineering.com,
        vbadigan@codeaurora.org, p.zabel@pengutronix.de, marex@denx.de,
        swboyd@chromium.org, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210204120547.15381-1-yann.gautier@foss.st.com>
 <20210204120547.15381-3-yann.gautier@foss.st.com>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <c1531549-29da-25dc-cada-f61edbc5f2fd@intel.com>
Date:   Fri, 5 Feb 2021 08:33:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20210204120547.15381-3-yann.gautier@foss.st.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/02/21 2:05 pm, yann.gautier@foss.st.com wrote:
> From: Yann Gautier <yann.gautier@foss.st.com>
> 
> Since [1], the erase argument for mmc_erase() function is saved in
> erase_arg field of card structure. It is preferable to use it instead of
> hard-coded MMC_SECURE_ERASE_ARG, which from eMMC 4.51 spec is not
> recommended:
> "6.6.16 Secure Erase
> NOTE Secure Erase is included for backwards compatibility. New system
> level implementations (based on v4.51 devices and beyond) should use
> Erase combined with Sanitize instead of secure erase."
> 
>  [1] commit 01904ff77676 ("mmc: core: Calculate the discard arg only once")
> 

Did you experience an issue because of this?  You could add that to the
commit message.

There does not seem to be a need for secure erase, so:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>


> Signed-off-by: Yann Gautier <yann.gautier@foss.st.com>
> ---
>  drivers/mmc/core/mmc_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 39a478874ca3..63524551a13a 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -2110,7 +2110,7 @@ static int mmc_test_rw_multiple(struct mmc_test_card *test,
>  	if (mmc_can_erase(test->card) &&
>  	    tdata->prepare & MMC_TEST_PREP_ERASE) {
>  		ret = mmc_erase(test->card, dev_addr,
> -				size / 512, MMC_SECURE_ERASE_ARG);
> +				size / 512, test->card->erase_arg);
>  		if (ret)
>  			ret = mmc_erase(test->card, dev_addr,
>  					size / 512, MMC_ERASE_ARG);
>