Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Feb 2021 09:38:50 +0100
From:   Christian Brauner <christian.brauner@ubuntu.com>
To:     Andreas Oetken <ennoerlangen@googlemail.com>
Cc:     Ley Foon Tan <ley.foon.tan@intel.com>,
        linux-kernel@vger.kernel.org,
        Andreas Oetken <ennoerlangen@gmail.com>,
        Andreas Oetken <andreas.oetken@siemens.com>
Subject: Re: [PATCH] nios2: fixed broken sys_clone syscall
Message-ID: <20210205083850.d5tcnyawnxismwfn@wittgenstein>
References: <20210205082338.584931-1-ennoerlangen@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210205082338.584931-1-ennoerlangen@gmail.com>
Precedence: bulk

On Fri, Feb 05, 2021 at 09:23:38AM +0100, Andreas Oetken wrote:
> From: Andreas Oetken <andreas.oetken@siemens.com>
> 
> The tls pointer must be pushed on the stack prior to calling nios2_clone
> as it is the 5th function argument. Prior handling of the tls pointer was
> done inside former called function copy_thread_tls using the r8 register
> from the current_pt_regs directly. This was a bad design and resulted in
> the current bug introduced in 04bd52fb.
> 
> Fixes: 04bd52fb ("nios2: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args")
> Signed-off-by: Andreas Oetken <andreas.oetken@siemens.com>
> ---

Thanks for catching this!
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>