Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1807432pxb; Fri, 5 Feb 2021 01:47:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJz931HYQwzlUBWCeLxfhkInM93uiD+TD9sPJG0sOLdxtBt/Fi1mUKqXwWcOyAbXeoegSZik X-Received: by 2002:a50:ee10:: with SMTP id g16mr2786249eds.62.1612518439752; Fri, 05 Feb 2021 01:47:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612518439; cv=none; d=google.com; s=arc-20160816; b=EtnI3Qg1WGpF0zOWcdDvC3CUnrVytwSBdrIjikCPfNkhfiyzK0Mt7NtLuFPRHpR8Ie ISScl+z8bIFko1YL9YgX/kd00mQvsXD0wvURCEE+N785ZSPaX0UvIAr3WXRvO856hm9y LcLmivpEjGOLvd3PIJEojpYdJdkd4hG/Te8W2cD0IJKwKna122asDZ8bKWGnFz0hGsPk 6cIMNyYThiV7sI0Y0KCYFS6//AUbONVYGnX+ux38eu8VV6cvK03K1Y8fKgigEZ4jnCAO RPlFznHBUpuOGwmSvSZrqLl3gkaj6r/NUSNPVHmVfQNbey8IIQElpQeC85P7EcH6m3TL ahCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=t7muh3inJHITkfGTZ2ENvs1TNyZ31H3Cq+bBF6aZrfY=; b=0DhgL7pUcoHFcFvxD6Zj1Gg34ks/dEKigXf3LitiYY6C5cRwb5I5o5+6XczQ8R7wyg c/WkiFvlqKLXgahlPXIW1K9a2hTuXQzZR8rx7qbvAYdP4TG4g31A4TX7fzsWUDkRecgo 4Ft8DZ0eUkBsrszH7sUBKJAcas8IiQdEr3LIUyHIi0aKJdG1eHavcPNXlxDe6g3xVoNs vr5BjP//6K5IAfOLbgnX0Yz41W4I2rQJMAaje+pOiKdVCiWweCxTCEE6DMNb3AkTO1uD HYSwjbzkMMSJJgxVE8+ha3QcI+Ew0GX6VQ1OpNxaUf7dJcCSZEaRBEfqE6G3dJ7olrne jcjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m12si4932888ejx.144.2021.02.05.01.46.54; Fri, 05 Feb 2021 01:47:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229824AbhBEJp6 (ORCPT + 99 others); Fri, 5 Feb 2021 04:45:58 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:12437 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229789AbhBEJnr (ORCPT ); Fri, 5 Feb 2021 04:43:47 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DX9Rr5VF6zjJT0; Fri, 5 Feb 2021 17:42:00 +0800 (CST) Received: from localhost.localdomain (10.69.192.58) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Fri, 5 Feb 2021 17:42:58 +0800 From: Daode Huang To: , CC: , , Subject: [PATCH] media: rc/ite-cir: replace spin_lock_irqsave by spin_lock in hard IRQ Date: Fri, 5 Feb 2021 17:39:11 +0800 Message-ID: <1612517951-119798-1-git-send-email-huangdaode@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.58] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is redundant to do irqsave and irqrestore in hardIRQ context. Signed-off-by: Daode Huang --- drivers/media/rc/ite-cir.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c index 0c62295..4a51ca80 100644 --- a/drivers/media/rc/ite-cir.c +++ b/drivers/media/rc/ite-cir.c @@ -262,7 +262,6 @@ static void ite_set_carrier_params(struct ite_dev *dev) static irqreturn_t ite_cir_isr(int irq, void *data) { struct ite_dev *dev = data; - unsigned long flags; irqreturn_t ret = IRQ_RETVAL(IRQ_NONE); u8 rx_buf[ITE_RX_FIFO_LEN]; int rx_bytes; @@ -271,7 +270,7 @@ static irqreturn_t ite_cir_isr(int irq, void *data) ite_dbg_verbose("%s firing", __func__); /* grab the spinlock */ - spin_lock_irqsave(&dev->lock, flags); + spin_lock(&dev->lock); /* read the interrupt flags */ iflags = dev->params.get_irq_causes(dev); @@ -287,17 +286,14 @@ static irqreturn_t ite_cir_isr(int irq, void *data) /* drop the spinlock, since the ir-core layer * may call us back again through * ite_s_idle() */ - spin_unlock_irqrestore(&dev-> - lock, - flags); + spin_unlock(&dev->lock); /* decode the data we've just received */ ite_decode_bytes(dev, rx_buf, rx_bytes); /* reacquire the spinlock */ - spin_lock_irqsave(&dev->lock, - flags); + spin_lock(&dev->lock); /* mark the interrupt as serviced */ ret = IRQ_RETVAL(IRQ_HANDLED); @@ -314,7 +310,7 @@ static irqreturn_t ite_cir_isr(int irq, void *data) } /* drop the spinlock */ - spin_unlock_irqrestore(&dev->lock, flags); + spin_unlock(&dev->lock); ite_dbg_verbose("%s done returning %d", __func__, (int)ret); -- 2.8.1