Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210129082726.19406-1-ruifeng.zhang0110@gmail.com>
 <YBPNAoitmgnTxiqQ@kroah.com> <CAG7+-3NGUgryomKB=_W=p9nADPJVnns_x9oWpAFCEei7RiyrOA@mail.gmail.com>
 <CAJZ5v0gh1y14mipnwJKE+-7FKzasMMTTzZY_dTpuepHGjyK-xg@mail.gmail.com> <CAG7+-3N=vonV+8y0bTXXh72vJGUqMrjyu_d4sztzpPkrPj7KeQ@mail.gmail.com>
In-Reply-To: <CAG7+-3N=vonV+8y0bTXXh72vJGUqMrjyu_d4sztzpPkrPj7KeQ@mail.gmail.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 5 Feb 2021 12:39:28 +0100
Message-ID: <CAJZ5v0gvkF7y6a7ZeNippUAyWd7FfSKh4BmGS+ckT_HNkpQBTw@mail.gmail.com>
Subject: Re: [PATCH] RFC syscore: add suspend type to syscore
To:     Ruifeng Zhang <ruifeng.zhang0110@gmail.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        ruifeng.zhang1@unisoc.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>, ke.wang@unisoc.com,
        nianfu.bai@unisoc.com, orson.zhai@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, Feb 5, 2021 at 11:28 AM Ruifeng Zhang
<ruifeng.zhang0110@gmail.com> wrote:
>
> Rafael J. Wysocki <rafael@kernel.org> 于2021年2月4日周四 下午9:38写道：
> >
> > On Thu, Feb 4, 2021 at 10:07 AM Ruifeng Zhang
> > <ruifeng.zhang0110@gmail.com> wrote:
> > >
> > > Greg KH <gregkh@linuxfoundation.org> 于2021年1月29日周五 下午4:53写道：
> > > >
> > > > On Fri, Jan 29, 2021 at 04:27:26PM +0800, Ruifeng Zhang wrote:
> > > > > From: Ruifeng Zhang <ruifeng.zhang1@unisoc.com>
> > > > >
> > > > > Suspend type contains s2ram and s2idle, but syscore is only
> > > > > available for S2RAM.
> > > >
> > > > Who else needs this?
> > > In the s2idle suspend and resume, some vendors want to do some
> > > things, for example the vendor implemented the watchdog driver.
> >
> > Do that in the platform operations then.
> >
> > Adding the syscore stuff to the suspend-to-idle flow is not an option, sorry.
> Excause me, I really still want to know the reason.

The conditions to run syscore operations are: with one CPU online and
with disabled interrupts on that CPU.  They are not satisfied in the
suspend-to-idle flow.  Moreover, none of the existing syscore
operations need to be executed for suspend-to-idle except for the
timekeeping suspend, but this is done for a special reason.

> My requirement is that the watchdog need disable when the system s2idle.
> If don't, the watchdog will bark when system resume.

So disabled it from s2idle_ops->prepare() or
suspend_ops->prepare_late() if device suspend is too early for you.