Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1890103pxb; Fri, 5 Feb 2021 04:10:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJzOPQYTObJURrwPr6KLObKcyCKy3Dclpp13QWSa/ZBwP59+ljafGqd2AlDgohqfWpRsNXXr X-Received: by 2002:a17:906:fb9a:: with SMTP id lr26mr3908531ejb.474.1612527019937; Fri, 05 Feb 2021 04:10:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612527019; cv=none; d=google.com; s=arc-20160816; b=k0x+EX6JhvqPSvD4/CELRAsQl+DOvTR2RbGJH8royjozgAFtm1zwHqSULmEhtsnxWb NoYKqZnyemXO+C+tDztWFsfHjt7kKlUCEfGBjMzaV0TPjn6ukmAuGW3PgvgHi/hODyd5 yzD3ss1EcdwyrYl24y5SdrA5NSxUQNcIzCZ1LQB2M3q2rRE1uG/N4reo6pMVZXJMvXf7 HlcYINsUuJ/ZF+T9sgedRdQgXS1qEn60VRDkcGnafgTPfdeZ1xMckt+9kJ7JjBDVkqn3 F4tebBKxH8pAe4mqUOzcmpLk5m6wlHxKX4wIJah33cHzWCItfky/9yt0BRgnsClVhEKs EvfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=isg0DesRi/Hq2hLl7475jjCCpMIFm0fEZvxPt8FgJLo=; b=XCxN7t/XKCxOmOYXuUNMRcsvjiSDtxt7Yi1rSxvy2QXR2a/4P2IysaKSRdtNBcHtPU KJWrQ/Y8ey6HS/xStGWsmqZrf6ZjXbuRoKlPbF8ZujtIrecHcED+mYfJ35yt2UFvlEBP Ng/0bD8IF/vl6gMgpvF9lDvlZWHyLV21bgtqsjUyKq3KchsIKVd2o4Hi4DhIs8VG37By YoGHs9gJKk3WfPmtBHSiyICk8nQmpoiWlCBVLeVobUreznI4WdTO1JjMZBI2+HEYOiXz rZDGkexjC8suq+zsuV0teqfQKDTrg/PS+t2frMnSPK9LQh9nh7cUSFHROWrBemzdSHa5 Wzqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=jpaHqKqw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hq38si4784180ejc.21.2021.02.05.04.09.53; Fri, 05 Feb 2021 04:10:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=jpaHqKqw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231366AbhBEMHz (ORCPT + 99 others); Fri, 5 Feb 2021 07:07:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231724AbhBEMF3 (ORCPT ); Fri, 5 Feb 2021 07:05:29 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83AE6C06178B for ; Fri, 5 Feb 2021 04:04:48 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id c4so7373097wru.9 for ; Fri, 05 Feb 2021 04:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=isg0DesRi/Hq2hLl7475jjCCpMIFm0fEZvxPt8FgJLo=; b=jpaHqKqw488gWf1n6/9/udYV2FiCAjfu+wJVkv7/nJWzRHiYYaJ1oybvNbMCKEWb5w rdSF7QAF8Rx9oEXs86EDbP8y4H0Mvh3KoWMEqQuiEiJ5Va0PiXsOYIe6bV5V+ue2sBu6 HohRwGqHjPwQwe/SdxJIgQL2f1SZ5AAPGLWd3xwnDosnM0iWrrEWeStKmEBODxloI8sG OBOsWaKFLxk/J2tkylxu8kk7WVYwv/vmMlLTG6QB5Blrhiq3PWp/BA3MlwYFt8ycTbSp xMUVrTE5+QtvQ4cvPe5bz6HDyyaGXsOvkjokI3n31dwPl44EEFJYL9FLADnCyjGf28ih /NWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=isg0DesRi/Hq2hLl7475jjCCpMIFm0fEZvxPt8FgJLo=; b=nRD062Y49B+GyhgLSf/xQ2zRRsQ8Ohx5FB893rXc6Aj31S2wYs4r3ePlRF2ybDbBxA Gw6i0hzykY8BnySAlAwp1Qyd/jPq5WHDbViP1iS6UIqdQ1ANguXWknUQEagAQu9zLDdv bLBA+zM3l2iMMENn9UtGtbu6WdpQ2F4jBoXgR7btQA2yhUVzDepBtXOvJT9fwL5L5tkQ m8fzqNN+wNUb9i+IRs0jsOk2/qsIotCKvvj9MiMFXt3IUqJE1irq6Wp4MXsy0fTQkgfw Xpe4QsNoToUP6qlHTPsBhBCa0L5f+9SrsgbiDy7sPXZU9/dtU12uqn+dr7HF3h0Rya0R BQOA== X-Gm-Message-State: AOAM533/uFDsfz56eLijVse9XzUI16RQzhs9DgswteoYkE+LMQiPMNkW ky/0FJlDmIa6NY1r9jCQDtC6EQ== X-Received: by 2002:adf:8464:: with SMTP id 91mr4577259wrf.188.1612526687361; Fri, 05 Feb 2021 04:04:47 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id o12sm11814435wrx.82.2021.02.05.04.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 04:04:46 -0800 (PST) Date: Fri, 5 Feb 2021 13:04:45 +0100 From: Jiri Pirko To: Oleksandr Mazur Cc: netdev@vger.kernel.org, dsahern@gmail.com, jiri@nvidia.com, davem@davemloft.net, linux-kernel@vger.kernel.org, kuba@kernel.org Subject: Re: [PATCH iproute2-next V3] devlink: add support for port params get/set Message-ID: <20210205120445.GF4652@nanopsycho.orion> References: <20210202130445.5950-1-oleksandr.mazur@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202130445.5950-1-oleksandr.mazur@plvision.eu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, Feb 02, 2021 at 02:04:45PM CET, oleksandr.mazur@plvision.eu wrote: >Add implementation for the port parameters >getting/setting. >Add bash completion for port param. >Add man description for port param. > >Example: >$ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value false cmode runtime > >$ devlink port param show netdevsim/netdevsim0/0 name test_port_parameter >netdevsim/netdevsim0/0: > name test_port_parameter type driver-specific > values: > cmode runtime value false > >$ devlink port -jp param show netdevsim/netdevsim0/0 name test_port_parameter >{ > "param": { > "netdevsim/netdevsim0/0": [ { > "name": "test_port_parameter", > "type": "driver-specific", > "values": [ { > "cmode": "runtime", > "value": false > } ] > } ] > } >} > >Signed-off-by: Oleksandr Mazur Looks fine. Reviewed-by: Jiri Pirko