Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 9kBijDSxWMYDTTaEpPbcTQPYxfggIkBkkYXbyQTNrGA2solyV4SPNGZ/mEoyhn/LNcLNFb/FaK
 Af/0MeowVdHL0FTiL8sb6a7qnpZFGmc/lH9hKIxmSVEhuCNU7MiQ2DMFnmsUf+MS3mvQBODhQN
 fTUvWwW9hyBjDNMUXhQS06NHgCHiBOOkGtnbAqC235xkJUwG87wzK9bIcnCsERW/psbzi9D66h
 hHUJ4MA1k7mwewTWkC/d624YG5rjcPSyP88Vou+bQvVSBJO8fIL8W83hQ2k7SyyEFIbTvGGwkR
 CXM=
From:   "nakamura.shun@fujitsu.com" <nakamura.shun@fujitsu.com>
To:     'John Garry' <john.garry@huawei.com>,
        "will@kernel.org" <will@kernel.org>,
        "mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
        "leo.yan@linaro.org" <leo.yan@linaro.org>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "jolsa@redhat.com" <jolsa@redhat.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX
Thread-Topic: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX
Thread-Index: AQHW+WMHTGeMdPN4T0+BYj0CxDS1qqpFEjAAgADvEKCAA3DPIA==
Date:   Fri, 5 Feb 2021 12:09:30 +0000
Message-ID: <OSBPR01MB46007C599F706F3C56B20E64F7B29@OSBPR01MB4600.jpnprd01.prod.outlook.com>
References: <20210202125140.1785583-1-nakamura.shun@jp.fujitsu.com>
 <57c6b89d-e0b2-3df4-8dcf-2cc71f772cb4@huawei.com>
 <OSBPR01MB4600991FC47D2E5A7E013F0CF7B49@OSBPR01MB4600.jpnprd01.prod.outlook.com>
In-Reply-To: <OSBPR01MB4600991FC47D2E5A7E013F0CF7B49@OSBPR01MB4600.jpnprd01.prod.outlook.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b420603-da9c-4632-1d07-08d8c9cee429
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2021 12:09:30.0611
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NJZn8BZPpJbtktJVbKn/Alqxc8z2+SfxF9iNKlHrxa385SWSR28qOx24xzmcyILFleq2QXULsj8mTRYILlfff32xoNhV5WfjJfzcTDy1IJU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB1587
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, John

> > Apart from that, I think that we're a bit uncertain about patch 3/4
> What are your concerns?
> I think it's okay for perf to read a new event code with a number at the =
beginning.

The impact of this fix is on {name} and later rules.
parse_events.l uses {name} only in one place.
The only rule defined after {name} is {name_tag}.

I think the point of current fix is that the rules defined after {name} are=
 not misrecognize and the syntax is not broken.=20
{name_tag} starts with ', but {name} does not contain'.
Therefore, the corrected {name} does not misrecognize the {name_tag}, and I=
 think there is no problem.

Best Regards
Shunsuke

> -----Original Message-----
> From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
> Behalf Of nakamura.shun@fujitsu.com
> Sent: Wednesday, February 3, 2021 4:02 PM
> To: 'John Garry' <john.garry@huawei.com>; will@kernel.org;
> mathieu.poirier@linaro.org; leo.yan@linaro.org; peterz@infradead.org;
> mingo@redhat.com; acme@kernel.org; mark.rutland@arm.com;
> alexander.shishkin@linux.intel.com; jolsa@redhat.com; namhyung@kernel.org
> Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: RE: [PATCH v5 0/4] perf vendor events: Support PMU events for A6=
4FX
>=20
> Hi, John
>=20
> > Just some things to note:
> > - please pick up and apply reviewed-by tags granted from previous
> > reviews if explicitly granted, subject to making any trivial changes
> > requested If any significant changes are made, then don't pick up
> > theses tags or drop them (if they were picked up earlier)
> I will fix.
>=20
> > - I'd say that it's best not to send my patch in 1/4, but better to
> > mention the series which this is based on in your cover letter Sending
> > my patch is only going to make the maintainers (Arnaldo) life more diff=
icult to
> track these things.
> I will fix.
>=20
> > Apart from that, I think that we're a bit uncertain about patch 3/4
> What are your concerns?
> I think it's okay for perf to read a new event code with a number at the =
beginning.
>=20
> Best Regards
> Shunsuke
>=20
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel