Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210123100608.2349629-1-yeyunfeng@huawei.com> <20210123100608.2349629-2-yeyunfeng@huawei.com>
In-Reply-To: <20210123100608.2349629-2-yeyunfeng@huawei.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 5 Feb 2021 13:46:26 +0100
Message-ID: <CAJZ5v0jOwfau2dPVnrAjv01dOGY+8i8o-2gr72fNa0Fug1CV=w@mail.gmail.com>
Subject: Re: [PATCH 2/2] powercap/intel_rapl: Use topology interface in rapl_init_domains()
To:     Yunfeng Ye <yeyunfeng@huawei.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        "Zhang, Rui" <rui.zhang@intel.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        hushiyuan@huawei.com, hewenliang4@huawei.com, caihongda@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jan 23, 2021 at 11:07 AM Yunfeng Ye <yeyunfeng@huawei.com> wrote:
>
> It's not a good way to access the phys_proc_id of cpuinfo directly.
> So using topology_physical_package_id(cpu) instead.
>
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>

Srinivas, Rui, any concerns?

> ---
>  drivers/powercap/intel_rapl_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
> index 5f3d39b8212a..8888adcb3927 100644
> --- a/drivers/powercap/intel_rapl_common.c
> +++ b/drivers/powercap/intel_rapl_common.c
> @@ -547,7 +547,7 @@ static void rapl_init_domains(struct rapl_package *rp)
>
>                 if (i == RAPL_DOMAIN_PLATFORM && rp->id > 0) {
>                         snprintf(rd->name, RAPL_DOMAIN_NAME_LENGTH, "psys-%d",
> -                               cpu_data(rp->lead_cpu).phys_proc_id);
> +                               topology_physical_package_id(rp->lead_cpu));
>                 } else
>                         snprintf(rd->name, RAPL_DOMAIN_NAME_LENGTH, "%s",
>                                 rapl_domain_names[i]);
> --
> 2.27.0
>