Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: I0RQXoqhb8eQw1usaUYHzw6fQNMRPhL2NaNp20B8nqnk7HiRbeJaboxnmmg3IpOiqBuVOMeyll
 JG8i/x7N8MTw==
IronPort-SDR: mkUckrG34FQjlWbQInn1qN7/g3VW/ZmvfgPktbzaQbPAvpXJCi0YN6LEAoJT0CLTRRq54cdfo+
 wNeW4T2KhTSw==
Date:   Fri, 5 Feb 2021 08:39:43 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     dsterba@suse.cz, clm@fb.com, josef@toxicpanda.com,
        dsterba@suse.com, Miao Xie <miaox@cn.fujitsu.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs/btrfs: Fix raid6 qstripe kmap'ing
Message-ID: <20210205163943.GD5033@iweiny-DESK2.sc.intel.com>
References: <20210128061503.1496847-1-ira.weiny@intel.com>
 <20210203155648.GE1993@suse.cz>
 <20210204152608.GF1993@suse.cz>
 <20210205035236.GB5033@iweiny-DESK2.sc.intel.com>
 <20210205153441.GK1993@twin.jikos.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210205153441.GK1993@twin.jikos.cz>
User-Agent: Mutt/1.11.1 (2018-12-01)
Precedence: bulk

On Fri, Feb 05, 2021 at 04:34:41PM +0100, David Sterba wrote:
> On Thu, Feb 04, 2021 at 07:52:36PM -0800, Ira Weiny wrote:
> > On Thu, Feb 04, 2021 at 04:26:08PM +0100, David Sterba wrote:
> > > On Wed, Feb 03, 2021 at 04:56:48PM +0100, David Sterba wrote:
> > > > On Wed, Jan 27, 2021 at 10:15:03PM -0800, ira.weiny@intel.com wrote:
> > > > > From: Ira Weiny <ira.weiny@intel.com>
> > > > Changelog is good, thanks. I've added stable tags as the missing unmap
> > > > is a potential problem.
> > > 
> > > There are lots of tests faling, stack traces like below. I haven't seen
> > > anything obvious in the patch so that needs a closer look and for the
> > > time being I can't add the patch to for-next.
> > 
> > :-(
> > 
> > I think I may have been off by 1 on the raid6 kmap...
> > 
> > Something like this should fix it...
> > 
> > diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
> > index b8a39dad0f00..dbf52f1a379d 100644
> > --- a/fs/btrfs/raid56.c
> > +++ b/fs/btrfs/raid56.c
> > @@ -2370,7 +2370,7 @@ static noinline void finish_parity_scrub(struct btrfs_raid_bio *rbio,
> >                         goto cleanup;
> >                 }
> >                 SetPageUptodate(q_page);
> > -               pointers[rbio->real_stripes] = kmap(q_page);
> > +               pointers[rbio->real_stripes - 1] = kmap(q_page);
> 
> Oh right and tests agree it works.
> 
> >         }
> >  
> >         atomic_set(&rbio->error, 0);
> > 
> > Let me roll a new version.
> 
> No need to, I'll fold the fixup. Thanks.

Oh cool thanks!  :-D
Ira