Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2114365pxb;
        Fri, 5 Feb 2021 09:15:58 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwu0FPPJFp2txReRjmYDKf05J75tvY9n8n1al68rM8rxnsPKz77ALrKhGO3hl3FIOe0hvMq
X-Received: by 2002:aa7:d149:: with SMTP id r9mr2713586edo.38.1612545357975;
        Fri, 05 Feb 2021 09:15:57 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1612545357; cv=none;
        d=google.com; s=arc-20160816;
        b=YpE/vsOT5o6T6yz3y1FI0uVMu0x+EAE6i7zqYzlnNmAaIzI5mrCyV4fNtHCY9EBaDX
         F9LN4w8k+xx9YsodVtv+KD+1tFIoyzwxM72QvaFiXmS3YsBDC4wG9dYREws9pOZ3dPs5
         k19Zw4iokbOMcI9T3o0NHSf/85aR+O7rkRMn57MS0nA1j4A436Qi6N774NR3EYsFsujt
         EmRvKwRWvrqc0HdEQWYGuQA8n31q3TAVpwygxlEHp/NPoxjGgCgr5b50+D53Apm3qAq7
         Tp/jepo9qi6iGx1wj099o5+R2Tm5ipD7HNsFCkB/RrQEe9aR0n0YptYHvgC4TP2Vi6vq
         N6zg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:message-id:date:references
         :in-reply-to:subject:to:dkim-signature:dkim-signature:from;
        bh=gQFB7dmw4+3vdRIHDm/XbDrP844LNmQuHfHCy0vCXm8=;
        b=RkiI4ewIdwUPLKRaSjDLZJwN4LbleTcuyLEwquExQQRVCUJBXzJH8vwT812/rSJts+
         DGKbkDPn90+HEIrYm0NROq5LZj5wZ0fUnIvyi2fhPGyGLLu9pti6H4zjsTOAOEL28xQa
         wCBI6kQ4hU5Zd6Bzr6pzin3kpJsDLD12GS8Pt9DhZZXMuEb9eN1Z67Gjz34P7+PZrYj5
         4A7QdlOk5Q7fYYWR2VlYdHob0gyjlayg52ZnDU/5OR5Kc3AHyHQUgkKW+FJchgd+89TM
         TnrCrYkme6xg5u+y5kFMObJJwXCND/L0KoC8ORgZrQQTeGIC9upWdiC23JddF/MBUBF1
         RI1g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=ceEePKsG;
       dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=wM0sajUx;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id jz3si2602171ejc.700.2021.02.05.09.15.28;
        Fri, 05 Feb 2021 09:15:57 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=ceEePKsG;
       dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=wM0sajUx;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229539AbhBEPbo (ORCPT <rfc822;lkmldmj@gmail.com> + 99 others);
        Fri, 5 Feb 2021 10:31:44 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56394 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233162AbhBEP1h (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 Feb 2021 10:27:37 -0500
Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BF96C0617AB
        for <linux-kernel@vger.kernel.org>; Fri,  5 Feb 2021 09:09:18 -0800 (PST)
From:   Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020; t=1612544856;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=gQFB7dmw4+3vdRIHDm/XbDrP844LNmQuHfHCy0vCXm8=;
        b=ceEePKsGTssihu7M/4TE++AHEHeVu24gYxGrOsl0LMMhMcWiYpR7h0BGBGO0klDyWqvJdI
        Lhx/JZBnz91zgqE3C3Ce50beu1VwlAnL8Bv8DZA0Q8geShvgMDWdgVulTGL2N9oH2S8Ph8
        RAopcdemQNhU/NRlCMCEJBZ0xD0FHCltp4KtH/yIvZ0lp9BqVYUoFn7SWq4XC2ViTJJODZ
        XyhGFczUAACH34sY/bo1jSbl+rv2aart7CqbEyguMAE7JrSdZ6QaJFacBxh6YJlZ+bU3v3
        l2btkjgpEQWuPMwf5TrTEgCOBHaJhkDzavYy78MWbNsI8M4RzUrT8C/4nRaaTA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020e; t=1612544856;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=gQFB7dmw4+3vdRIHDm/XbDrP844LNmQuHfHCy0vCXm8=;
        b=wM0sajUxZgHRLiJtsFCMwL/CxlynMJNfle78OWeSxk1mPb0j/5XzSyUJ/saZdlwgZoyoW/
        yJT4Zhw4MFC8ZvDg==
To:     Li RongQing <lirongqing@baidu.com>, linux-kernel@vger.kernel.org,
        john.stultz@linaro.org
Subject: Re: [PATCH] alarmtimer: Do not mess with an enqueued hrtimer
In-Reply-To: <1609997600-13503-1-git-send-email-lirongqing@baidu.com>
References: <1609997600-13503-1-git-send-email-lirongqing@baidu.com>
Date:   Fri, 05 Feb 2021 18:07:35 +0100
Message-ID: <87o8gy8mug.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 07 2021 at 13:33, Li RongQing wrote:
> when an hrtimer is enqueued already, its expires should be not
> changed, otherwise, this will corrupts the ordering of the
> timerqueue RB tree, if other hrtimer is enqueued before this
> hrtimer is restarted, whole RB tree is completely hosed
>
> Fixes: 6cffe00f7d4e ("alarmtimer: Add functions for timerfd support")

I can't see what this fixes. alarm_restart() is only invoked when the
alarm has expired which means that the timer _cannot_ be queued.

Thanks,

        tglx