Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity
 from DT
To:     Pavel Machek <pavel@ucw.cz>,
        Sven Schuchmann <schuchmann@schleissheimer.de>
Cc:     Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20210204143726.27977-1-schuchmann@schleissheimer.de>
 <20210204145201.GB14305@duo.ucw.cz>
 <DB8P190MB063482D8E38C0529AD16A4D5D9B29@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM>
 <20210205102338.GA27854@amd>
From:   Jacek Anaszewski <jacek.anaszewski@gmail.com>
Message-ID: <c107d3b9-2141-7cad-837a-f8ef107df61c@gmail.com>
Date:   Fri, 5 Feb 2021 19:37:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210205102338.GA27854@amd>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Pavel,

On 2/5/21 11:23 AM, Pavel Machek wrote:
> Hi!
> 
>>>>       patternProperties:
>>>>         "(^led-[0-9a-f]$|led)":
>>>> @@ -99,6 +104,7 @@ examples:
>>>>                  reg = <0x1>;
>>>>                  color = <LED_COLOR_ID_RGB>;
>>>>                  function = LED_FUNCTION_CHARGING;
>>>> +               default-intensity = <100 0 0>;

How will you know which array position is for which child LED?
I presume DT child nodes are not guaranteed to be parsed in the order
of declaration?

>>>>
>>>>                  led-0 {
>>>>                      color = <LED_COLOR_ID_RED>;
>>>
>>> Should this go to leds-class-multicolor.yaml ?
>>
>> I think then all drivers should support it,  but I cannot change all drivers.
>> So I would only leave it in there.
> 
> It really should be in common binding, and no, that does not mean you
> need to change all the drivers.
> 
> Plus there's at most two of them at the moment.
> 
> Best regards,
> 							Pavel
> 

-- 
Best regards,
Jacek Anaszewski