Received: by 2002:a05:6520:2f93:b029:af:d4db:7a05 with SMTP id 19csp2376571lkf; Fri, 5 Feb 2021 11:31:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyEjHQBTbQxFaeebZVqyoOqoDvJOVdDDkjrIuBlZ0wOKkdXohkRZgngklKYiPzzPjHCU4u+ X-Received: by 2002:a17:906:296a:: with SMTP id x10mr5413344ejd.240.1612553485543; Fri, 05 Feb 2021 11:31:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612553485; cv=none; d=google.com; s=arc-20160816; b=i5JIRNQhqO46S/6dXJLEf3H178uWQPpghJK3emE852kfqdFJTCCpqQoJ3yCPGDEIe9 UkoJq8psPSQC6qgr0tt+D0aOR5YAxiiM2+Ry5J6PFA8z2gNKl1M4y/B15j5lbnsLfkNL 8LZWdhPtsJCGllwpxgg5q2lZFZxByQXN3JIroMH6jqI2+G32lqiEdyCNAEJpABGnitDE n716/0OsqNvk6xofiNxzlxavp820Ia4QriLz772x6D0eFJsX9nWKPS2ptgkV2cF8FMAV KxBphB6o4guocLmplSH8KEvWbM33CE7aTmZdtdO+OCZNHoSjsa/9l7g83ENCJwnoE3O+ /2Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=mI1G3cH7PLmlJ9KfMthcAEbRgR1IRL22HixY0S4DBBU=; b=v+FBqLRQB6eSEXGtuUSz/1IaQnJRL3pH97u9hDz6MzQLhYCKRq0lbDTIDGaYvQ9L5f m1ZZACJEgtK5P7OPguFym/F5EitGsMKEGElCXFpLz7klWG4wR1n3II5fqqFks0FfYWZ3 e7nw1kgt71vqj9hk1mxhy54uOnjWNuzSPKAJifQ9dnCt1Yzqjj69Up6D7xxtxpKtmg49 W6FSqJ7KZlkyKaav0u8RRW4sEqECCx1cZLUmz5TxWhY7sHhIAVLh4w4MWJ/hFS0pHp29 F+aDyEehWcPOqmuT67S9VBIIOkpolNeqV0PJ1W8O5PofpWFR03gc2jLylBXqyRjFlRUK XqQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lTTRFWao; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hr3si5877913ejc.380.2021.02.05.11.31.00; Fri, 05 Feb 2021 11:31:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lTTRFWao; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233407AbhBERrk (ORCPT + 99 others); Fri, 5 Feb 2021 12:47:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:56636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233456AbhBERoB (ORCPT ); Fri, 5 Feb 2021 12:44:01 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 36AE664E3D; Fri, 5 Feb 2021 19:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612553143; bh=BgOb+TcaSnI3cZprwqZFAncIJNytyVytQSSPUe6lB9c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lTTRFWaovu+4k6fALquGQu3mNtOYEKG2KuGug9GcoNhj6+CO+pTluxrvkx5PAqRNb zR2xeh8wu8Vyah5gKiDi6w7z1SENCZeVB3Kd+G+KPa+ZsirrXigeDNUMAdYBiUant3 SbZtdnZWaD7udDIiZ//6gpPjZjyMwskvsKZ2Fq4+zVO8rh8470GbzZguVvirsq5QUI cbVh9TQNt0FkCWLmojPfjtWjZU0Mj5oPJjPkhFQpobuDdreeX/nlpNvKlbnr7LfXOW z3bcpBeHSVxlL5QFn0lwzm+Pksnyehfj+ChQIgeplt0OxVu9oisK5GKsaUxtIKHxWX kY+TgwqQMn+Hw== Date: Fri, 5 Feb 2021 11:25:42 -0800 From: Jakub Kicinski To: Hariprasad Kelam Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "davem@davemloft.net" , "willemdebruijn.kernel@gmail.com" , "andrew@lunn.ch" , Sunil Kovvuri Goutham , Linu Cherian , "Geethasowjanya Akula" , Jerin Jacob Kollanukkaran , Subbaraya Sundeep Bhatta Subject: Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration Message-ID: <20210205112542.335c6bd5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Feb 2021 14:15:01 +0000 Hariprasad Kelam wrote: > > > Will add multi advertised mode support in near future. > > > > Looking at patch 6 it seems like the get side already supports multiple modes, > > although the example output only lists supported no advertised. > > > > Is the device actually doing IEEE autoneg or just configures the speed, lanes > > etc. according to the link mode selected? > > Device supports IEEE autoneg mode. Agreed get_link_ksetting returns multiple modes . > But set side firmware code designed in such way that it handles single mode. Upon > Successful configuration firmware updates advertised modes to shared memory > such that kernel will read and updates to ethtool. It needs to be symmetric, get needs to reflect what set specified.