Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: DBWi9nnisSoA8Cdvker+OvShWDgaPtMv0Jwpi8AQhzj/Ly7SSvlMl+ZAOuOsdgSEWN4CXgQMPU
 Ep1HDkmi/vRQ==
IronPort-SDR: mGPnbtVPmJJg3NoDEko5zdYAU1Mj7/ClAx+9ByIq3ztejbmWSU/Op+By5NXQ/Xnnb32UcH1EmV
 HSs71W5HB+0g==
Message-ID: <0f63aaa63cb4217f772aa702fac5c44a3ac110b6.camel@linux.intel.com>
Subject: Re: [PATCH 1/2] powercap/intel_rapl: Use topology interface in
 rapl_add_package()
From:   Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Yunfeng Ye <yeyunfeng@huawei.com>,
        "Zhang, Rui" <rui.zhang@intel.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        hushiyuan@huawei.com, hewenliang4@huawei.com, caihongda@huawei.com
Date:   Fri, 05 Feb 2021 09:07:28 -0800
In-Reply-To: <CAJZ5v0hNryYqKfTZfRjN+KJVgw973G+vi9SrT4mGTPz_TTT2ng@mail.gmail.com>
References: <20210123100608.2349629-1-yeyunfeng@huawei.com>
         <CAJZ5v0hNryYqKfTZfRjN+KJVgw973G+vi9SrT4mGTPz_TTT2ng@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2021-02-05 at 13:45 +0100, Rafael J. Wysocki wrote:
> On Sat, Jan 23, 2021 at 11:07 AM Yunfeng Ye <yeyunfeng@huawei.com>
> wrote:
> > It's not a good way to access phys_proc_id and cpu_die_id directly.
> > So using topology_physical_package_id(cpu) and topology_die_id(cpu)
> > instead.
> > 
> > Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> 
> Srinivas, Rui, any concerns?
Looks good.

Thanks,
Srinivas

> 
> > ---
> >  drivers/powercap/intel_rapl_common.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/powercap/intel_rapl_common.c
> > b/drivers/powercap/intel_rapl_common.c
> > index c9e57237d778..5f3d39b8212a 100644
> > --- a/drivers/powercap/intel_rapl_common.c
> > +++ b/drivers/powercap/intel_rapl_common.c
> > @@ -1309,7 +1309,6 @@ struct rapl_package *rapl_add_package(int
> > cpu, struct rapl_if_priv *priv)
> >  {
> >         int id = topology_logical_die_id(cpu);
> >         struct rapl_package *rp;
> > -       struct cpuinfo_x86 *c = &cpu_data(cpu);
> >         int ret;
> > 
> >         if (!rapl_defaults)
> > @@ -1326,10 +1325,11 @@ struct rapl_package *rapl_add_package(int
> > cpu, struct rapl_if_priv *priv)
> > 
> >         if (topology_max_die_per_package() > 1)
> >                 snprintf(rp->name, PACKAGE_DOMAIN_NAME_LENGTH,
> > -                        "package-%d-die-%d", c->phys_proc_id, c-
> > >cpu_die_id);
> > +                        "package-%d-die-%d",
> > +                        topology_physical_package_id(cpu),
> > topology_die_id(cpu));
> >         else
> >                 snprintf(rp->name, PACKAGE_DOMAIN_NAME_LENGTH,
> > "package-%d",
> > -                        c->phys_proc_id);
> > +                        topology_physical_package_id(cpu));
> > 
> >         /* check if the package contains valid domains */
> >         if (rapl_detect_domains(rp, cpu) || rapl_defaults-
> > >check_unit(rp, cpu)) {
> > --
> > 2.27.0
> >