Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210129082726.19406-1-ruifeng.zhang0110@gmail.com>
 <YBPNAoitmgnTxiqQ@kroah.com> <CAG7+-3NGUgryomKB=_W=p9nADPJVnns_x9oWpAFCEei7RiyrOA@mail.gmail.com>
 <CAJZ5v0gh1y14mipnwJKE+-7FKzasMMTTzZY_dTpuepHGjyK-xg@mail.gmail.com>
 <CAG7+-3N=vonV+8y0bTXXh72vJGUqMrjyu_d4sztzpPkrPj7KeQ@mail.gmail.com> <CAJZ5v0gvkF7y6a7ZeNippUAyWd7FfSKh4BmGS+ckT_HNkpQBTw@mail.gmail.com>
In-Reply-To: <CAJZ5v0gvkF7y6a7ZeNippUAyWd7FfSKh4BmGS+ckT_HNkpQBTw@mail.gmail.com>
From:   Ruifeng Zhang <ruifeng.zhang0110@gmail.com>
Date:   Sat, 6 Feb 2021 04:03:41 +0800
Message-ID: <CAG7+-3MHSbGt6h+fJUEcF9Hqf8RpJLyG=7ySx_qeMvaQNpubuA@mail.gmail.com>
Subject: Re: [PATCH] RFC syscore: add suspend type to syscore
To:     "Rafael J. Wysocki" <rafael@kernel.org>
Cc:     Greg KH <gregkh@linuxfoundation.org>, ruifeng.zhang1@unisoc.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>, ke.wang@unisoc.com,
        nianfu.bai@unisoc.com, orson.zhai@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Rafael J. Wysocki <rafael@kernel.org> =E4=BA=8E2021=E5=B9=B42=E6=9C=885=E6=
=97=A5=E5=91=A8=E4=BA=94 =E4=B8=8B=E5=8D=887:39=E5=86=99=E9=81=93=EF=BC=9A
>
> On Fri, Feb 5, 2021 at 11:28 AM Ruifeng Zhang
> <ruifeng.zhang0110@gmail.com> wrote:
> >
> > Rafael J. Wysocki <rafael@kernel.org> =E4=BA=8E2021=E5=B9=B42=E6=9C=884=
=E6=97=A5=E5=91=A8=E5=9B=9B =E4=B8=8B=E5=8D=889:38=E5=86=99=E9=81=93=EF=BC=
=9A
> > >
> > > On Thu, Feb 4, 2021 at 10:07 AM Ruifeng Zhang
> > > <ruifeng.zhang0110@gmail.com> wrote:
> > > >
> > > > Greg KH <gregkh@linuxfoundation.org> =E4=BA=8E2021=E5=B9=B41=E6=9C=
=8829=E6=97=A5=E5=91=A8=E4=BA=94 =E4=B8=8B=E5=8D=884:53=E5=86=99=E9=81=93=
=EF=BC=9A
> > > > >
> > > > > On Fri, Jan 29, 2021 at 04:27:26PM +0800, Ruifeng Zhang wrote:
> > > > > > From: Ruifeng Zhang <ruifeng.zhang1@unisoc.com>
> > > > > >
> > > > > > Suspend type contains s2ram and s2idle, but syscore is only
> > > > > > available for S2RAM.
> > > > >
> > > > > Who else needs this?
> > > > In the s2idle suspend and resume, some vendors want to do some
> > > > things, for example the vendor implemented the watchdog driver.
> > >
> > > Do that in the platform operations then.
> > >
> > > Adding the syscore stuff to the suspend-to-idle flow is not an option=
, sorry.
> > Excause me, I really still want to know the reason.
>
> The conditions to run syscore operations are: with one CPU online and
> with disabled interrupts on that CPU.  They are not satisfied in the
> suspend-to-idle flow.  Moreover, none of the existing syscore
> operations need to be executed for suspend-to-idle except for the
> timekeeping suspend, but this is done for a special reason.
>
> > My requirement is that the watchdog need disable when the system s2idle=
.
> > If don't, the watchdog will bark when system resume.
>
> So disabled it from s2idle_ops->prepare() or
> suspend_ops->prepare_late() if device suspend is too early for you.
I will seriously consider your suggestions, thank you very much.