Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210205195113.20277-1-rajmohan.mani@intel.com>
 <20210205195113.20277-3-rajmohan.mani@intel.com> <CACeCKafY=mFBC-6VKsnOgZc6f0Y_FraQrdRnbKQ-k448OgExDQ@mail.gmail.com>
In-Reply-To: <CACeCKafY=mFBC-6VKsnOgZc6f0Y_FraQrdRnbKQ-k448OgExDQ@mail.gmail.com>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Fri, 5 Feb 2021 12:06:41 -0800
Message-ID: <CACeCKafOshFWFC2pCCitNqBA1WtumhTHyC7rJgwpcLosup7j9A@mail.gmail.com>
Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_types: Support disconnect
 events without partners
To:     Rajmohan Mani <rajmohan.mani@intel.com>
Cc:     Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Feb 5, 2021 at 12:05 PM Prashant Malani <pmalani@chromium.org> wrote:
>
> Hi Raj,
>
> On Fri, Feb 5, 2021 at 11:52 AM Rajmohan Mani <rajmohan.mani@intel.com> wrote:
> >
> > There are certain scenarios, where a disconnect event might
> > occur on a Type-C port with no port partners. This is required
> > to enable communication to Burnside Bridge USB4 retimers.
> >
> > Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com>
> minor commit message nit (apologies for not spotting this earlier):
>
> This patch alone doesn't add support for the "without partners" part
> (that comes in the next patch).
> This one purely adds support for disconnect events. So might be good
> to update the commit message if possible.
Sorry, I just noticed that I interpreted the ordering of the patches
incorrectly, so this commit message is fine as is and I retract my
nit.

> But otherwise LGTM, so:
>
> Reviewed-by: Prashant Malani <pmalani@chromium.org>