From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Zach Brown'" <zach.brown@oracle.com>
Cc: "'Andrew Morton'" <akpm@osdl.org>,
       "'Suparna Bhattacharya'" <suparna@in.ibm.com>,
       <linux-kernel@vger.kernel.org>, "linux-aio" <linux-aio@kvack.org>
Subject: RE: [patch] clean up unused kiocb variables
Date: Thu, 21 Sep 2006 13:26:20 -0700
Message-ID: <000101c6ddbc$334248d0$ff0da8c0@amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AcbdtODucUrlwQboQJijMzNglaA2WAABspeg
In-Reply-To: <4512E910.6000308@oracle.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 835
Lines: 27

Zach Brown wrote on Thursday, September 21, 2006 12:34 PM
> Chen, Kenneth W wrote:
> > Any reason why we keep these two variables around for kiocb structure?
> 
> If there is a good one I've forgotten it.
> 
> > They are not used anywhere.
> 
> Indeed.


Let's remove them.  We can always add them back if there is a need.


> The ki_retried users all seem pretty questionable, too.  How about
> removing all that stuff?

Suparna wanted them around for debug purpose at one point.  I don't know
whether that is still the case right now.  At least I can wrap it around
with #if DEBUG.

- Ken
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/