Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Feb 2021 13:53:21 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Hans Verkuil <hverkuil@xs4all.nl>
Cc:     Takashi Iwai <tiwai@suse.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Matwey V. Kornilov" <matwey@sai.msu.ru>,
        Robert Foss <robert.foss@linaro.org>
Subject: Re: [PATCH] media: pwc: Fix the URB buffer allocation
Message-ID: <YB0/wTjYqE9IgtXZ@lunn.ch>
References: <20210121202855.17400-1-tiwai@suse.de>
 <7afd0612-de36-60b1-6650-6f8de24a7145@xs4all.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7afd0612-de36-60b1-6650-6f8de24a7145@xs4all.nl>
Precedence: bulk

On Fri, Feb 05, 2021 at 01:36:43PM +0100, Hans Verkuil wrote:
> Hi Takashi,
> 
> Thank you for this patch, but it clashes with another patch trying to do the same thing
> that has already been merged in our tree:
> 
> https://patchwork.linuxtv.org/project/linux-media/patch/20210104170007.20625-1-matwey@sai.msu.ru/
> 
> I do prefer your patch over the one already merged since it is a bit simpler, but
> shouldn't the calls to dma_sync_single_for_cpu() and dma_sync_single_for_device()
> in pwc-if.c also use urb->dev->bus->controller?
> 
> Also, Matwey's patch uses urb->dev->bus->sysdev instead of urb->dev->bus->controller.
> How does 'sysdev' relate to 'controller'? I think 'controller' is the right device to
> use, but either seems to work when I test it with my pwc webcam.

Hi Hans

A quick grep in driver/usb show that all but one dma mapping operation
use sysdev. The one other case uses controller. So the numbers suggest
controller is wrong, sysdev is correct.

But maybe ask GregKH?

	   Andrew