Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Feb 2021 14:26:11 +0000
From:   Chris Down <chris@chrisdown.name>
To:     linux-kernel@vger.kernel.org
Cc:     Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        John Ogness <john.ogness@linutronix.de>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Andrew Morton <akpm@linux-foundation.org>, kernel-team@fb.com
Subject: Re: [PATCH] printk: Userspace format enumeration support
Message-ID: <YB1Vgyi11cBkL1P7@chrisdown.name>
References: <YBwU0G+P0vb9wTwm@chrisdown.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <YBwU0G+P0vb9wTwm@chrisdown.name>
User-Agent: Mutt/2.0.5 (da5e3282) (2021-01-21)
Precedence: bulk

Oh, and one more I just spotted and will fix in v2 after other feedback is in:

Chris Down writes:
>+static void store_printk_fmt_sec(const struct module *mod, const char **start,
>+				 const char **end)
>+{
>+	struct printk_fmt_sec *ps = NULL;
>+	const char **fptr = NULL;
>+	size_t size = 0;
>+
>+	ps = kmalloc(sizeof(struct printk_fmt_sec), GFP_KERNEL);
>+	if (!ps)
>+		return;
>+
>+	ps->module = mod;
>+	ps->start = start;
>+	ps->end = end;
>+
>+	for (fptr = ps->start; fptr < ps->end; fptr++)
>+		size += strlen(*fptr) + 1;

This still works, but is out of date and doesn't account for the module and 
comma, so results in one more unnecessary round trip doing seq_buf_alloc.