Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210205122033.1345204-1-unixbhaskar@gmail.com>
 <CAOQ4uxhy2XG=EBg6f6xwSNZnYU9z0vx0W6Q2pXDT_KOTKWPZ8A@mail.gmail.com> <YB1EHZL5gbVGO1Xx@ArchLinux>
In-Reply-To: <YB1EHZL5gbVGO1Xx@ArchLinux>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Fri, 5 Feb 2021 17:56:00 +0200
Message-ID: <CAOQ4uxgNQ9wCp_0jBiFf8Vzze6FG=pVO04gxF4wki4fePRTauA@mail.gmail.com>
Subject: Re: [PATCH] fs: notify: inotify: Replace a common bad word with
 better common word
To:     Bhaskar Chowdhury <unixbhaskar@gmail.com>,
        Amir Goldstein <amir73il@gmail.com>, Jan Kara <jack@suse.cz>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Feb 5, 2021 at 3:12 PM Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote:
>
> On 14:45 Fri 05 Feb 2021, Amir Goldstein wrote:
> >On Fri, Feb 5, 2021 at 2:20 PM Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote:
> >>
> >>
> >>
> >> s/fucked/messed/
> >>
> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> >> ---
> >>  fs/notify/inotify/inotify_user.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
> >> index 59c177011a0f..0a9d1a81edf0 100644
> >> --- a/fs/notify/inotify/inotify_user.c
> >> +++ b/fs/notify/inotify/inotify_user.c
> >> @@ -455,7 +455,7 @@ static void inotify_remove_from_idr(struct fsnotify_group *group,
> >>         /*
> >>          * We found an mark in the idr at the right wd, but it's
> >>          * not the mark we were told to remove.  eparis seriously
> >> -        * fucked up somewhere.
> >> +        * messed up somewhere.
> >>          */
> >>         if (unlikely(found_i_mark != i_mark)) {
> >>                 WARN_ONCE(1, "%s: i_mark=%p i_mark->wd=%d i_mark->group=%p "
> >> --
> >> 2.30.0
> >>
> >
> >Same comment as the previous attempt:
> >
> >https://lore.kernel.org/linux-fsdevel/20181205094913.GC22304@quack2.suse.cz/
> >
> >Please remove the part of the comment that adds no valuable information
> >and fix grammar mistakes.
> >
> I am not sure Amir ..could you please pinpoint that.
>

        /*
         * We found a mark in the idr at the right wd, but it's
         * not the mark we were told to remove.
         */

Thanks,
Amir.