Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1612248702-49626-1-git-send-email-yang.lee@linux.alibaba.com>
In-Reply-To: <1612248702-49626-1-git-send-email-yang.lee@linux.alibaba.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 5 Feb 2021 13:51:49 +0100
Message-ID: <CAJZ5v0hOv6w3ZHq0JkW4tk4yp5w3ssYiGyg_-uvLm1NzPwKPvg@mail.gmail.com>
Subject: Re: [PATCH] apei: erst: remove unneeded semicolon
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     Kees Cook <keescook@chromium.org>,
        Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
        Borislav Petkov <bp@alien8.de>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 2, 2021 at 7:52 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Eliminate the following coccicheck warning:
> ./drivers/acpi/apei/erst.c:691:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/acpi/apei/erst.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
> index 2e0b0fc..b959721 100644
> --- a/drivers/acpi/apei/erst.c
> +++ b/drivers/acpi/apei/erst.c
> @@ -688,7 +688,7 @@ static int __erst_read_from_storage(u64 record_id, u64 offset)
>                         break;
>                 if (erst_timedout(&timeout, SPIN_UNIT))
>                         return -EIO;
> -       };
> +       }
>         rc = apei_exec_run(&ctx, ACPI_ERST_GET_COMMAND_STATUS);
>         if (rc)
>                 return rc;
> --

Applied as 5.12 material, thanks!