Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2369985pxb; Fri, 5 Feb 2021 16:42:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYHJAH7GkRcxFA1lHmP32XZh1E2SiHdFTpGCRw7BcQqAJU+CXo2HIU+wv1OImlu6HbJ0zQ X-Received: by 2002:a17:907:2d11:: with SMTP id gs17mr4012272ejc.20.1612572162409; Fri, 05 Feb 2021 16:42:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612572162; cv=none; d=google.com; s=arc-20160816; b=UfFlcQUVtVYk2+P0AEM5/HbIdNOPDmbe3kojkQhg+tts6Hw2mrEZRsgNav8gSmNaQh pCI3yQtUhO7gQLXDHLd/Hlu5dbkubVIDkHpzUQgEG9d7N+SoZYaUmjF+R+ENMRlvFgNy Y3AYnjyI0eA3hk8RNc/Ej+qfKM1GcmzhYDh+G3e2d7uBfLs79fEyvCQMKjhhUwSobU1p KLBBRAqJFp96LaGbvw/riLVswyZ3jiZTMmFX202Pl3CRe3Xff6pPXdbPkwjLyinf5hwi VqqdKasQyHSNnHHhBIfBYDyy4V0JkS9w4jFvGACzCu4bqB+Ed0NLWeFhAJY0kTAgzagn 2Mag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YKFr1OaX41tKIse84FOjUPRg1BE34jxdlTucijfIY9A=; b=b4Un1RkjzsX9b7E0wscnHysY7WTNylRQT2G/lNiUEGnoteIaMyLPn5NL/esTKI1wEe 0BLAO+YqgHV4Pvu8agk6lRbMpfEmkhMZp5eSsXRLq0Tp3TZqRYN1MklP4553NeTdiUTV oTBgKuiY2czDHTDTJF4a4iNtshjmkiTpMsj2u3E6oh85yGkp2bzZib8huxh7owFSaaqJ ajTph2EOY/fmnZmhZ3FxeCdWyzhR+QUrSqSV38zBKyDblBy0DQaoDWWcJhoI/MfaZx5D ZjzxkmWmAiR4LDhVuw+gfyV13lZhW/vY09hIm6RFEk8cksQvV9bFq69e04O0zkY3HOaf bakA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZepuP1vJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si6138300ejf.666.2021.02.05.16.42.17; Fri, 05 Feb 2021 16:42:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZepuP1vJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbhBFAl1 (ORCPT + 99 others); Fri, 5 Feb 2021 19:41:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231574AbhBEKpk (ORCPT ); Fri, 5 Feb 2021 05:45:40 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9AE4C06121D for ; Fri, 5 Feb 2021 02:44:55 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id f16so5603305wmq.5 for ; Fri, 05 Feb 2021 02:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YKFr1OaX41tKIse84FOjUPRg1BE34jxdlTucijfIY9A=; b=ZepuP1vJJm3kKPUewIRk46pmuLELCyDb+Qh9AsLM6E5TR3XN4ukpfm1PWxj/2NhwJU X862Ccf7p9drsc7jDclJofPfFVKW7s5JVT8Up9PFCmmDX088CELK6Uhb4VGOoao9cQCq q7ZRgiNYUKbmZ68Y9OYRCDKBZARd5UYWMmA2/y6c+HAYz0isjUfNE1ApANz/8Mvz7Nl6 LIOO3ivKWpKQnuBCKrMePdV/TMfuNtyULlKJCXIBPJLqHdyI3qUfLQFrFMI5PPJqkCo+ 1991EE67qnEW/ClGxQgfURYK/ATpJW0+Sp2IG8yDGB1wVXyNri281n4QgofowG9Vy4lX ZsPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YKFr1OaX41tKIse84FOjUPRg1BE34jxdlTucijfIY9A=; b=X3y6P9Mb5ZUdXd4MpHRtqCo8bAit4hoph/SyRw/U04veYQTNpjHZWqxFqldP4vVd04 JKT5pWmx2/dAgDiBHkbf8gkq5o3ivTiJF7t32I8Zhgbhvf0cVk7vsKjVuVBBcrpi5RXW H1DEEaDGMNGgsqgLiyl+QbNy9varjTk17ucQ9SmHgpPBRqdgW+ffcLUUI0rdqYXxmANs 4z7P/NAn/P2CDvq3Iv4psD3CPZbhl3rTrUUEvNu2EcfE5Ngws4wMuceL7BuUlNQBcsNW jNXw3CahhTA5EQzKXcUII643Zj7qXDV6my5H+59GZEx3TcBXLYtchQyFCq5L6o7dIS84 6vgw== X-Gm-Message-State: AOAM531ULLJtANIjRe6mAw8DTT3p/WAG9mci8wd8pDcx1wsd8oBpvM/z F9nP+52totBeSY+9oMvJ9Ny02g== X-Received: by 2002:a1c:6a09:: with SMTP id f9mr3026083wmc.104.1612521894738; Fri, 05 Feb 2021 02:44:54 -0800 (PST) Received: from localhost.localdomain ([2a02:2450:102f:d6a:38fd:e0db:ea01:afc8]) by smtp.gmail.com with ESMTPSA id u4sm11300233wrr.37.2021.02.05.02.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 02:44:54 -0800 (PST) From: Robert Foss To: robert.foss@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, mchehab@kernel.org, robh+dt@kernel.org, angelogioacchino.delregno@somainline.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Rob Herring , Sakari Ailus , Nicolas Boichat , Andrey Konovalov Cc: Tomasz Figa , Azam Sadiq Pasha Kapatrala Syed , Sarvesh Sridutt , Laurent Pinchart , Jonathan Marek Subject: [PATCH v4 03/22] media: camss: Replace trace_printk() with dev_dbg() Date: Fri, 5 Feb 2021 11:43:55 +0100 Message-Id: <20210205104414.299732-4-robert.foss@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210205104414.299732-1-robert.foss@linaro.org> References: <20210205104414.299732-1-robert.foss@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org trace_printk() should not be used in production code, since extra memory is used for special buffers whenever trace_puts() is used. Replace it with dev_dbg() which provides all of the desired debugging functionality. Signed-off-by: Robert Foss Suggested-by: Nicolas Boichat --- Changes since v3: - Nicolas: Create this patch drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 5 +++-- drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c index a1b56b89130d..85b9bcbc7321 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c @@ -12,6 +12,7 @@ #include #include +#include "camss.h" #include "camss-vfe.h" #define VFE_0_HW_VERSION 0x000 @@ -936,8 +937,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", - value0, value1); + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", + value0, value1); if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe); diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c index 84c33b8f9fe3..f7e00a2de393 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c @@ -12,6 +12,7 @@ #include #include +#include "camss.h" #include "camss-vfe.h" #define VFE_0_HW_VERSION 0x000 @@ -1069,8 +1070,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", - value0, value1); + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", + value0, value1); if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe); -- 2.27.0