Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sven Schuchmann <schuchmann@schleissheimer.de>
To:     Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>
CC:     Rob Herring <robh+dt@kernel.org>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: AW: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity
 from DT
Thread-Topic: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity
 from DT
Thread-Index: AQHW+wNFjslKsenf3karGguwydAae6pIFI+AgAEq5dA=
Date:   Fri, 5 Feb 2021 09:57:44 +0000
Message-ID: <DB8P190MB063482D8E38C0529AD16A4D5D9B29@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM>
References: <20210204143726.27977-1-schuchmann@schleissheimer.de>
 <20210204145201.GB14305@duo.ucw.cz>
In-Reply-To: <20210204145201.GB14305@duo.ucw.cz>
Accept-Language: de-DE, en-US
Content-Language: de-DE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 67c8e130-47a7-42be-9ed5-08d8c9bc7c49
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2021 09:57:44.8133
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: ba05321a-a007-44df-8805-c7e62d5887b5
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: msKR+Bdn3EPcQdBv85uU/d7siSLH1SYGmHrvW/ThCkqwOcQqF96LYViZ2dAsj5Az9lZFWfH1XbGkVPtzU4jjbRjY4o0YcW8agQoHZpAeRNU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAP190MB0839
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Pavel, hello Dan,

> > diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/=
Documentation/devicetree/bindings/leds/leds-
> lp50xx.yaml
> > index c192b5feadc7..2bc25b2fc94d 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> > @@ -65,6 +65,11 @@ patternProperties:
> >            This property denotes the LED module number(s) that is used =
on the
> >            for the child node.  The LED modules can either be used stan=
d alone
> >            or grouped into a module bank.
> > +      default-intensity:
> > +        minItems: 1
> > +        maxItems: 3
> > +        description:
>=20
> Do we need more than three for RGBW and similar?

AFAIK the lp50xx supports only RGB. So I would go for that.


> >      patternProperties:
> >        "(^led-[0-9a-f]$|led)":
> > @@ -99,6 +104,7 @@ examples:
> >                 reg =3D <0x1>;
> >                 color =3D <LED_COLOR_ID_RGB>;
> >                 function =3D LED_FUNCTION_CHARGING;
> > +               default-intensity =3D <100 0 0>;
> >
> >                 led-0 {
> >                     color =3D <LED_COLOR_ID_RED>;
>=20
> Should this go to leds-class-multicolor.yaml ?=20

I think then all drivers should support it,  but I cannot change all driver=
s.=20
So I would only leave it in there.


> Can you make example
> <255 120 0> or something like that, so make it clear it is not
> percent?

Sure

Best Regards,

   Sven