Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751679AbWIUWLU (ORCPT ); Thu, 21 Sep 2006 18:11:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751675AbWIUWLU (ORCPT ); Thu, 21 Sep 2006 18:11:20 -0400 Received: from mx1.redhat.com ([66.187.233.31]:7323 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1750726AbWIUWLT (ORCPT ); Thu, 21 Sep 2006 18:11:19 -0400 Date: Thu, 21 Sep 2006 18:10:58 -0400 From: Dave Jones To: Pavel Machek Cc: "Rafael J. Wysocki" , Andrew Morton , LKML Subject: Re: [PATCH -mm 5/6] mm: Print first block offset for swap areas Message-ID: <20060921221058.GM26683@redhat.com> Mail-Followup-To: Dave Jones , Pavel Machek , "Rafael J. Wysocki" , Andrew Morton , LKML References: <200609202120.58082.rjw@sisk.pl> <200609202154.39377.rjw@sisk.pl> <20060921213253.GF2245@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060921213253.GF2245@elf.ucw.cz> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 26 On Thu, Sep 21, 2006 at 11:32:53PM +0200, Pavel Machek wrote: > On Wed 2006-09-20 21:54:38, Rafael J. Wysocki wrote: > > In order to use a swap file with swsusp we need to know the offset at which > > its swap header is located. However, the swap header is always located in the > > first block of the swap file and it's quite easy to make sys_swapon() print > > the offset of the swap file's (or swap partition's) first block. > > > > Signed-off-by: Rafael J. Wysocki > > ACK. > > (main point of this is that it changes user-visible printk, but that's > probably okay, and way better than changing /proc files...) As a user-interface, "read the number from dmesg that swapon printk'd and add that to your boot command line" is pretty damned awful. It means that it's next to impossible for a distro installer to support suspend-to-swapfile. It's also incredibly fragile to rely on that file always remaining in that part of the disk. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/