Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210125185333.3337463-1-dlatypov@google.com>
In-Reply-To: <20210125185333.3337463-1-dlatypov@google.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Fri, 5 Feb 2021 15:32:50 -0800
Message-ID: <CAFd5g477HrqPzh38QdbOMvRr3=kvDBnxpx1QjbnUN4hkvCyt7w@mail.gmail.com>
Subject: Re: [PATCH] Documentation: kunit: add tips.rst for small examples
To:     Daniel Latypov <dlatypov@google.com>
Cc:     David Gow <davidgow@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 25, 2021 at 10:53 AM Daniel Latypov <dlatypov@google.com> wrote:
>
> ./usage.rst contains fairly long examples and explanations of things
> like how to fake a class and how to use parameterized tests (and how you
> could do table-driven tests yourself).
>
> It's not exactly necessary information, so we add a new page with more
> digestible tips like "use kunit_kzalloc() instead of kzalloc() so you
> don't have to worry about calling kfree() yourself" and the like.
>
> Change start.rst to point users to this new page first and let them know
> that usage.rst is more of optional further reading.
>
> Signed-off-by: Daniel Latypov <dlatypov@google.com>

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>