Date: Thu, 21 Sep 2006 15:19:51 -0700
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: Martin Bligh <mbligh@google.com>, "Frank Ch. Eigler" <fche@redhat.com>,
       Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>, prasanna@in.ibm.com,
       Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
       Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
       Paul Mundt <lethal@linux-sh.org>,
       linux-kernel <linux-kernel@vger.kernel.org>, Jes Sorensen <jes@sgi.com>,
       Tom Zanussi <zanussi@us.ibm.com>,
       Richard J Moore <richardj_moore@uk.ibm.com>,
       Michel Dagenais <michel.dagenais@polymtl.ca>,
       Christoph Hellwig <hch@infradead.org>,
       Greg Kroah-Hartman <gregkh@suse.de>,
       Thomas Gleixner <tglx@linutronix.de>, William Cohen <wcohen@redhat.com>,
       ltt-dev@shafik.org, systemtap@sources.redhat.com,
       Alan Cox <alan@lxorguk.ukuu.org.uk>,
       Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] Linux Kernel Markers 0.6 for 2.6.17
Message-Id: <20060921151951.d36d2fc4.rdunlap@xenotime.net>
In-Reply-To: <20060921215644.GA27651@Krystal>
References: <20060921215644.GA27651@Krystal>
Organization: YPO4
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1933
Lines: 77

On Thu, 21 Sep 2006 17:56:44 -0400 Mathieu Desnoyers wrote:

> Hi Mathieu,

In your next version, please use a space between "if" and "(".

> --- /dev/null
> +++ b/kernel/marker.c
> @@ -0,0 +1,178 @@
> +/* Pointers can be used around preemption disabled */
> +static int marker_get_pointers(const char *name,
> +	struct marker_pointers *ptrs)
> +{
> +	if(!(ptrs->call && ptrs->jmpselect && ptrs->jmpcall
> +			&& ptrs->jmpinline && ptrs->jmpover)) {
> +		return ENOENT;
> +	}
> +}
> +
> +int marker_set_probe(const char *name, marker_probe_func *probe,
> +		enum marker_type type)
> +{
> +	if(result) {
> +		printk(KERN_NOTICE
> +			"Unable to find kallsyms for markers in %s\n",
> +			name);
> +		goto unlock;
> +	}
> +
> +		case MARKER_CALL:
> +			if(*ptrs.call != __mark_empty_function) {
> +				result = EBUSY;
> +				printk(KERN_NOTICE
> +					"Probe already installed on "
> +					"marker in %s\n",
> +					name);
> +				goto unlock;
> +			}
> +		case MARKER_INLINE:
> +			if(*ptrs.jmpover == *ptrs.jmpinline) {
> +				result = ENODEV;
> +				printk(KERN_NOTICE
> +					"No inline probe exists "
> +					"for marker in %s\n",
> +					name);
> +				goto unlock;
> +			}
> +}
> +
> +void marker_disable_probe(const char *name, marker_probe_func *probe,
> +		enum marker_type type)
> +{
> +	if(result)
> +		goto unlock;
> +
> +		case MARKER_CALL:
> +			if(*ptrs.call == probe) {
> +				*ptrs.jmpselect = *ptrs.jmpover;
> +				*ptrs.call = __mark_empty_function;
> +			}
> +		case MARKER_INLINE:
> +			if(*ptrs.jmpselect == *ptrs.jmpinline)
> +				*ptrs.jmpselect = *ptrs.jmpover;
> +			break;
> +	if(!result && type == MARKER_CALL)
> +		synchronize_sched();
> +}
> 

Thanks.
---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/