Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: U/+N79u++vnZ8VUhF0+Q6RnItyO6gEkpnFnHS5V6YXHQ9qv3Yr5ku6e3Ps5zaJLJhbdL3zygxm
 Mqj9paEwndng==
IronPort-SDR: KFM8S8tiDOmPq7MD68erqsL7cRkFyJbtugSKuT6jXOfB2SS0Ua3XNKA6uUnESEWmyhRTtrCDFC
 AGacYmQyPwAA==
From:   Vinicius Costa Gomes <vinicius.gomes@intel.com>
To:     Song Yoong Siang <yoong.siang.song@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc:     netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Ong Boon Leong <boon.leong.ong@intel.com>,
        Voon Wei Feng <weifeng.voon@intel.com>,
        Wong Vee Khee <vee.khee.wong@intel.com>,
        Song Yoong Siang <yoong.siang.song@intel.com>
Subject: Re: [PATCH net 1/1] net: stmmac: set TxQ mode back to DCB after
 disabling CBS
In-Reply-To: <1612447396-20351-1-git-send-email-yoong.siang.song@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
References: <1612447396-20351-1-git-send-email-yoong.siang.song@intel.com>
Date:   Fri, 05 Feb 2021 14:38:57 -0800
Message-ID: <8735yap2bi.fsf@vcostago-mobl2.amr.corp.intel.com>
Precedence: bulk

Song Yoong Siang <yoong.siang.song@intel.com> writes:

> From: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
>
> When disable CBS, mode_to_use parameter is not updated even the operation
> mode of Tx Queue is changed to Data Centre Bridging (DCB). Therefore,
> when tc_setup_cbs() function is called to re-enable CBS, the operation
> mode of Tx Queue remains at DCB, which causing CBS fails to work.
>
> This patch updates the value of mode_to_use parameter to MTL_QUEUE_DCB
> after operation mode of Tx Queue is changed to DCB in stmmac_dma_qmode()
> callback function.
>
> Fixes: 1f705bc61aee ("net: stmmac: Add support for CBS QDISC")
> Suggested-by: Gomes, Vinicius <vinicius.gomes@intel.com>

Just a nitpick/formality, I would prefer if you used:

Suggested-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>

> Signed-off-by: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
> Signed-off-by: Song, Yoong Siang <yoong.siang.song@intel.com>

Patch looks good.

Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>

Cheers,
-- 
Vinicius