Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2475643pxb; Fri, 5 Feb 2021 20:43:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJygijNyAKWfl7gJ1UqfC67Zp2InL5vOklXfwPQxYoEgbsVK69olWKyaBH5Yw3K1NsX0hNKa X-Received: by 2002:a17:906:a20e:: with SMTP id r14mr7067072ejy.404.1612586632607; Fri, 05 Feb 2021 20:43:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612586632; cv=none; d=google.com; s=arc-20160816; b=d1b7gJYOipdZkP3NgS8/NEjbhVHSxW/ffhKT2It3MNw8NKUw7ZC05tB77aTN0pX0OR nNjC7Xw2jpOLw8O98dmyPOYlT5+QjyMQFQ/NLnYcM9MiiRu9/LPC/4Ex0rpvj+nmYzV7 I0wCmNejZIB5C7V+cf5oXT2w/oYBzf5I+zihsE9CfFElQTEVibMHBIw6bYHA83P3LVzx lPkqY7gHOiCFEjQI4uQliZm7yCWb4w1eaaZ5/QhoL0sjWHxW3cM4yyzWmz2yN1/O74yV Q/mgaZZn+gDNeEt+0tt26qAU2YSBAdWPVKy8dk4FpX8FhcLNmrkfHJ6uuuHCmXEwldFN HuKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=TZac0H6IstOdYjffdGKHHDVGEFmbQ7hZGZcMNcV+pPM=; b=1B47uemktnC8iKmF4z8YrHDpTejU022Hu3Fz4l9pJHiSLK4QeQFxirDaiA1gcbRdYd JOUTIRa+s7f+jhBvGS2J77eWJfMGeNVDuIfbw6iEbykN+qUEkh3sJiaw5HV0tATakYxC 4HZhC+oT9AuWdB73CGCTUafWPp9n9jecTwm4Zv2U2tGy6uDi6LGGvasK+1CsFPkdBquj 5SueOnJf4N4qnvTjKtxbH3/j1uuaQDc9vl7xovpzslyGBcH1R6GeofEE7p77gUSdBFEm He5X/6czu7uGFUItNnO1uhYsNQ9qUEVUPPgj5xca3UsKE90oSGIIZXVk/r5jk1MwfcP5 UvQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=GV4zHoCH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id uz17si6663260ejb.591.2021.02.05.20.43.27; Fri, 05 Feb 2021 20:43:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=GV4zHoCH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231252AbhBFEmv (ORCPT + 99 others); Fri, 5 Feb 2021 23:42:51 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:4853 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbhBFDXo (ORCPT ); Fri, 5 Feb 2021 22:23:44 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 05 Feb 2021 13:58:07 -0800 Received: from MacBook-Pro-10.local (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 5 Feb 2021 21:58:07 +0000 Subject: Re: [PATCH] mm: cma: support sysfs To: Suren Baghdasaryan , Minchan Kim CC: Andrew Morton , Greg Kroah-Hartman , John Dias , LKML , linux-mm References: <87d7ec1f-d892-0491-a2de-3d0feecca647@nvidia.com> <71c4ce84-8be7-49e2-90bd-348762b320b4@nvidia.com> <34110c61-9826-4cbe-8cd4-76f5e7612dbd@nvidia.com> <269689b7-3b6d-55dc-9044-fbf2984089ab@nvidia.com> From: John Hubbard Message-ID: Date: Fri, 5 Feb 2021 13:58:06 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612562287; bh=TZac0H6IstOdYjffdGKHHDVGEFmbQ7hZGZcMNcV+pPM=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=GV4zHoCH8XokZmyQqI1szC928lThgkfy3KmH5EvHhUZcx/d3boGoCWvI8uF1Oo1Qo 0lWEMoQ/6J+ljAHxVK3WbNNKw66PNHmF4FQT4ID11LeadB0Uf9egYQNEwedU/Uepsz Dw55iHFBKMOI/M0o7NrloO4RIbsI3Q/7LmAmD/9z6wP9vtM1+ZEu3HJkU4RjmrXa4y xSy5mXIRMvHhKx0pfdcY7cIsGeMfbRPgeBujeVzjpbuMoAeiJRjrUj2A0pgiWv8FOO 7lXecEbzimxVOECzNHp6qT/bSjFo7NGZcHwgglvAMX8xaCNpjsG7U5ktEn7E9a4Wcl EvvZqQ2mOJdSA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/5/21 1:52 PM, Suren Baghdasaryan wrote: >>>> I takes your suggestion something like this. >>>> >>>> [alloc_range] could be order or range by interval >>>> >>>> /sys/kernel/mm/cma/cma-A/[alloc_range]/success >>>> /sys/kernel/mm/cma/cma-A/[alloc_range]/fail >>>> .. >>>> .. >>>> /sys/kernel/mm/cma/cma-Z/[alloc_range]/success >>>> /sys/kernel/mm/cma/cma-Z/[alloc_range]/fail > > The interface above seems to me the most useful actually, if by > [alloc_range] you mean the different allocation orders. This would > cover Minchan's per-CMA failure tracking and would also allow us to > understand what kind of allocations are failing and therefore if the > problem is caused by pinning/fragmentation or by over-utilization. > I agree. That seems about right, now that we've established that cma areas are a must-have. thanks, -- John Hubbard NVIDIA