Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <90cf805f4be6ecf5887fe470af6db2d596dc46a3.camel@perches.com>
Subject: Re: [PATCH] checkpatch: Don't warn about colon termination in
 linker scripts
From:   Joe Perches <joe@perches.com>
To:     Chris Down <chris@chrisdown.name>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        kernel-team@fb.com
Date:   Fri, 05 Feb 2021 19:25:06 -0800
In-Reply-To: <YBwhqsc2TIVeid3t@chrisdown.name>
References: <YBwhqsc2TIVeid3t@chrisdown.name>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2021-02-04 at 16:32 +0000, Chris Down wrote:
> This check erroneously flags cases like the one in my recent printk
> enumeration patch[0], where the spaces are syntactic, and `section:' vs.
> `section :' is syntactically important:
> 
> ????ERROR: space prohibited before that ':' (ctx:WxW)
> ????#258: FILE: include/asm-generic/vmlinux.lds.h:314:
> ????+       .printk_fmts : AT(ADDR(.printk_fmts) - LOAD_OFFSET) {
> 
> 0: https://lore.kernel.org/patchwork/patch/1375749/

Remember to cc the checkpatch maintainers.

> Signed-off-by: Chris Down <chris@chrisdown.name>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> ?scripts/checkpatch.pl | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 4f8494527139..3bcffc5574ae 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5046,7 +5046,7 @@ sub process {
> ?				# A colon needs no spaces before when it is
> ?				# terminating a case value or a label.
> ?				} elsif ($opv eq ':C' || $opv eq ':L') {
> -					if ($ctx =~ /Wx./) {
> +					if ($ctx =~ /Wx./ and $realfile !~ m@.*\.lds\.h$@) {
> ?						if (ERROR("SPACING",
> ?							  "space prohibited before that '$op' $at\n" . $hereptr)) {
> ?							$good = rtrim($fix_elements[$n]) . trim($fix_elements[$n + 1]);