Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2484854pxb; Fri, 5 Feb 2021 21:08:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZDviin9qzBPgtiITonOvWyNt3k4tOTpFEaw6H+xdavupXn3joC4wLkTvdOfDNlWCgrILI X-Received: by 2002:a17:906:3a13:: with SMTP id z19mr7492744eje.317.1612588081635; Fri, 05 Feb 2021 21:08:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612588081; cv=none; d=google.com; s=arc-20160816; b=uGe5OebFfdFUJYD9D1G8EV6M6A7afKRucpKbI00/rWVVy/0q3EDhg1LYknVPTBs6Dr ZvctQnJG/XmfIMrPJxNK3k3DYOc91FJPHT2uy9R+iFU8Y9ho/gOBe1IXguekKR6ZAG4f xhbFFF6Fj77F3JWGEBbftBmk47hrhnFipWUAaqp8vkRPjUj7LnSn3u2wD8fMafS32oVM 5S2/rnEhx2Y8nlx4biSSmXxkURFXuKgX2ZqklCHg4t8KY+L7rVWyE15ocUPvf5N81TCZ lkzR592+uEkQZKKXWIKBpB6/ytXjOnMQeqDE7sjGCfYAhv38q9gmi4A7Q0+uH4glzABQ f8lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=BOfhpI6Pct7YOvRYywamiqV90GYlguNDYCZVZfdMFF4=; b=jyhgeWiwSMtG3wab0Oydm9+UP7JyFxLxLxwqEDLaz3RRvuXB+JCUya0UVw4nd76pw7 ZmpNGMF0rhwyK3E9bnPlf27z3gMqb0dcjB7aNRIFJ/SF+6zP/wAtT45Ba0xxYeVL0PYk SgdxBmiOvpEVSiLnmKNl2cTDftMpZ8j942xYDsJdRKmGA77fkjVkta59zCYYkTozuY9l xWqrLImAw1sCIj2AozXUlHI8jkeCnKT0kctcsGt7hSC7Lj+vyu/WRvJgk79Uax/s1jpl AJIULZzz9bR2p7KcUYQxNWGpPw0qkEPEYVPaU34e2iHBlwl3X9BTJOSf5zwQRU/FD8pq HBeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ijefe/7V"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x19si6099257edd.134.2021.02.05.21.07.37; Fri, 05 Feb 2021 21:08:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ijefe/7V"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229772AbhBFFG1 (ORCPT + 99 others); Sat, 6 Feb 2021 00:06:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230487AbhBFD7m (ORCPT ); Fri, 5 Feb 2021 22:59:42 -0500 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A35A9C061756; Fri, 5 Feb 2021 19:59:01 -0800 (PST) Received: by mail-qt1-x831.google.com with SMTP id e15so6602380qte.9; Fri, 05 Feb 2021 19:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BOfhpI6Pct7YOvRYywamiqV90GYlguNDYCZVZfdMFF4=; b=ijefe/7VuijxV7fXltuMQCv2CDhZQmJb4GneqOJpBl03bFpQ9R7lm3ZJn2qvYC3egj JtayyTyxDBGm3+RUiEWCUhdEJoY14xs59Q0n+zDOpAJ5m2SDDFbtfzPkFCPD4c4zm5dm H9A8GxySd9zaO16fTZM6YGk2nIU5HSdfU8T15TZRVJ+0gAtd747GNaTGJOYiTe160uB6 7J59DJnEIE74SZsWMQWBL8l4pW8wS/CZ+GDUblW8tX72x97QV9QcbEs9Y2INsOnM/rM6 81dlxRd9+nXqNLk9taTp/JsBueaXBVFEDg4WjvMd6nxce0aiRvurouTa243dlx4OJI6j pexA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=BOfhpI6Pct7YOvRYywamiqV90GYlguNDYCZVZfdMFF4=; b=Oztj+M/y1DQOBSmA9KC02MfWHBE2+cWZVGdzbD0dap6So1kh66vTnEox9uOBW/lapM A1gOuk9x12BSaiXeOqBfioDrrPfj7r5acEiLin+6R6VpDos7Euva7YcC1oMkOT9UqpB2 jA9xSwO6hiauROWgVjqdJFf3MTOYP41cwDkJ+17sjbmDbpk+MCSmsaWE8KvjlmzLslmc qLOxETWW1zKXrK8cX/+vd74dX9QIsMfFW+f+gPlGdir/aGDURh7SUftHoSHXbKTE1ea9 si0llxBWdJz/dkDQILC8sO0y7VQKTz1Yx2aWSEBQW+xreXpHhme5uL+imdmrcawggfRz jSrA== X-Gm-Message-State: AOAM533Mn22lsMRcN5xefMXDGovyaexZI7jQIbKw6DHYOER0lzSzhfwy qWxWnePyDAa4LLw2pcvzKI0= X-Received: by 2002:ac8:5d0d:: with SMTP id f13mr7172637qtx.317.1612583940812; Fri, 05 Feb 2021 19:59:00 -0800 (PST) Received: from localhost (dhcp-6c-ae-f6-dc-d8-61.cpe.echoes.net. [72.28.8.195]) by smtp.gmail.com with ESMTPSA id h5sm10540341qti.22.2021.02.05.19.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 19:59:00 -0800 (PST) Sender: Tejun Heo Date: Fri, 5 Feb 2021 22:58:09 -0500 From: Tejun Heo To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/8] mm: memcontrol: switch to rstat v2 Message-ID: References: <20210205182806.17220-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210205182806.17220-1-hannes@cmpxchg.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2021 at 01:27:58PM -0500, Johannes Weiner wrote: > This is version 2 of the memcg rstat patches. Updates since v1: > > - added cgroup selftest output (see test section below) (thanks Roman) > - updated cgroup selftest to match new kernel implementation > - added Fixes: tag to 'mm: memcontrol: fix cpuhotplug statistics flushing' (Shakeel) > - collected review & ack tags > - added rstat overview to 'mm: memcontrol: switch to rstat' changelog (Michal) > - simplified memcg_flush_lruvec_page_state() and removed cpu==-1 case (Michal) The whole series looks good to me. Please feel free to route the rstat patches with the rest of the series. Thanks. -- tejun