Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2487420pxb; Fri, 5 Feb 2021 21:14:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJx03WtgVHiZ/ZItV8SWZ2ylWd1j5QFyuHo7TtCAg+fay5imp4QzsuRzHEX/4pOszt0tGUnr X-Received: by 2002:a05:6402:208:: with SMTP id t8mr6834769edv.189.1612588499602; Fri, 05 Feb 2021 21:14:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612588499; cv=none; d=google.com; s=arc-20160816; b=G1Tfg2qiMzn+Asz2t7bAZ5zCO5uLPW0DfeFp4vE2HssfxsdasGLvwtVROgJ1De2fEE EZV3l1y5t1WcY4Emb+mWH6sAgXuHiQTxB+W/BGFDgTNaMVCJ5BTwoF5NuPwfCoT45jJ1 xM1/6hId7/YQCwniX8iF6dkAVJQY05WC4BbBRvaEc3GAX2EuiNrCQJNQzK0wdhKkxhM6 lHoIFd3Mi3TXS8j08QtHh10tgqYpWrtLG8Tqw4gYZm2a3Mo1Kl64/5u5yXg3CfNuqoiG 0ru30zyhqigfSwy1xTBOMt3TZo/2UFyMmLXnX/qU0l3DjWsl8YhcHyw3w+wcNYNujj7t u2qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7tNqLsfYX9gzibf9LwB4HQxkaRZ+2tGUkdroBxSOk2A=; b=URrZt0zMXsmKefS7RDmSlkS/PLJ6gBW7CWDYZBZuIdAZywEqxWLoQ2kXjj0n4v8FsZ pYbSbINh/xXVeO3b4OgkZuj3TOb1M3DQl2cz2tESzJFqyTSKvTM1F3oEWzUh5YhesQ+z IwJ/QW77wNlZd7OMVTx1PJ+NuuyXMTs7kS5LxGbHkljxsOH5tlz+6XRtS1sSA0ECm7Qt c+wQGkQ7ATX8KRHPLZHLd9C0Byr0zo4NblCmwsQqN25vkQ8PWUbOYQ5M8NulAPiyQkGO B7a1OU0eCNwDvfnc9faN0lmbwUcslw6qrHCvT5L3HaqQRC5NuBd8prRzwzh7Uh6IAAc/ qnpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jeSp4ZWD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i12si6359621ejr.344.2021.02.05.21.14.35; Fri, 05 Feb 2021 21:14:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jeSp4ZWD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231901AbhBFFLT (ORCPT + 99 others); Sat, 6 Feb 2021 00:11:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231314AbhBFEjb (ORCPT ); Fri, 5 Feb 2021 23:39:31 -0500 Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22B7FC0613D6 for ; Fri, 5 Feb 2021 20:38:51 -0800 (PST) Received: by mail-ua1-x92a.google.com with SMTP id 67so2848838uao.1 for ; Fri, 05 Feb 2021 20:38:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7tNqLsfYX9gzibf9LwB4HQxkaRZ+2tGUkdroBxSOk2A=; b=jeSp4ZWDa+2AdP7dQ54QhQ4gHYklqrtRaIc6KBcRn6T9e2cVRq02Ci0Ua4KWN2Dig+ QXUR9aNriY9noKbl1c0FLmhZCNjx41o0W9Km6L8+l3H28qzvTIXR/Vt+VfQmlLdIF1l4 AglCrYVfTUI88jvaJHN5Ali1/jP5vX9C4P8oQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7tNqLsfYX9gzibf9LwB4HQxkaRZ+2tGUkdroBxSOk2A=; b=BhmT2/wvlOlqAcCKmi2m6yKY/Afn1vgmQvJkB0htwE/GE9wVObdGrcPbSxi93C0klx jAYj3x/QzTqPAOkbYXbDrL7fmOT02eDpQJCdOls5zkVffYHSQ2i86hlZmd2NhE5mfCc6 yHDMzJuEkLrg862fYc+sUtIIDtfnakOOWEUAsrF32fet1Mf3qG9WycVJoAdo1z7LEBAX fSz153kGBXC9zKRl+nZRpHB+Vsq/GkH6mCMg0A7rjNBsHanZS3QesUN2Z+Ew4wTVgB4d QIgTtkwmjpDmLZFs2bY8eqXPQ6IK2N/225HNsBedPAN0EdiBeWZqMEy4q5OGhwPlekKs IlaQ== X-Gm-Message-State: AOAM533Q6JY5FbEjti/2FERLe9IkaN/RSjhDdVNS89uJQUvX2jTxssZc OOuJkynTYBR2PYIpKvYOLcrVIVUt1IYZ6JC+UI69Ww== X-Received: by 2002:ab0:3043:: with SMTP id x3mr5342812ual.88.1612586330175; Fri, 05 Feb 2021 20:38:50 -0800 (PST) MIME-Version: 1.0 References: <20210205104414.299732-1-robert.foss@linaro.org> <20210205104414.299732-4-robert.foss@linaro.org> In-Reply-To: <20210205104414.299732-4-robert.foss@linaro.org> From: Nicolas Boichat Date: Sat, 6 Feb 2021 12:38:39 +0800 Message-ID: Subject: Re: [PATCH v4 03/22] media: camss: Replace trace_printk() with dev_dbg() To: Robert Foss Cc: Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Rob Herring , angelogioacchino.delregno@somainline.org, Linux Media Mailing List , linux-arm-msm@vger.kernel.org, Devicetree List , lkml , AngeloGioacchino Del Regno , Rob Herring , Sakari Ailus , Andrey Konovalov , Tomasz Figa , Azam Sadiq Pasha Kapatrala Syed , Sarvesh Sridutt , Laurent Pinchart , Jonathan Marek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 5, 2021 at 6:44 PM Robert Foss wrote: > > trace_printk() should not be used in production code, > since extra memory is used for special buffers whenever > trace_puts() is used. > > Replace it with dev_dbg() which provides all of the desired > debugging functionality. > > Signed-off-by: Robert Foss > Suggested-by: Nicolas Boichat Thanks! Reviewed-by: Nicolas Boichat > --- > > Changes since v3: > - Nicolas: Create this patch > > > drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 5 +++-- > drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c > index a1b56b89130d..85b9bcbc7321 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c > @@ -12,6 +12,7 @@ > #include > #include > > +#include "camss.h" > #include "camss-vfe.h" > > #define VFE_0_HW_VERSION 0x000 > @@ -936,8 +937,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) > > vfe->ops->isr_read(vfe, &value0, &value1); > > - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", > - value0, value1); > + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", > + value0, value1); > > if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) > vfe->isr_ops.reset_ack(vfe); > diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c > index 84c33b8f9fe3..f7e00a2de393 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c > @@ -12,6 +12,7 @@ > #include > #include > > +#include "camss.h" > #include "camss-vfe.h" > > #define VFE_0_HW_VERSION 0x000 > @@ -1069,8 +1070,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) > > vfe->ops->isr_read(vfe, &value0, &value1); > > - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", > - value0, value1); > + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", > + value0, value1); > > if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) > vfe->isr_ops.reset_ack(vfe); > -- > 2.27.0 >