Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210129134855.195810-1-jolsa@redhat.com> <20210130234856.271282-1-jolsa@kernel.org>
 <20210130234856.271282-7-jolsa@kernel.org> <CAM9d7cg6qEeq--PPxyC9Bq8VNw91O_M+PgnNQ-Sk7n_tKOE1yg@mail.gmail.com>
 <YB1AihrsetqhIYIc@krava>
In-Reply-To: <YB1AihrsetqhIYIc@krava>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Sat, 6 Feb 2021 17:05:04 +0900
Message-ID: <CAM9d7chedaB7-ZsqpUYGnG9LBYOspd59Nq842Q_yCR4YWDQL9g@mail.gmail.com>
Subject: Re: [PATCH 06/24] perf daemon: Add config file support
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexei Budankov <abudankov@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Feb 5, 2021 at 9:56 PM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Fri, Feb 05, 2021 at 09:14:54PM +0900, Namhyung Kim wrote:
> > On Sun, Jan 31, 2021 at 8:49 AM Jiri Olsa <jolsa@kernel.org> wrote:
> > [SNIP]
> > > @@ -263,9 +605,16 @@ static int __cmd_start(struct daemon *daemon, struct option parent_options[],
> > >         signal(SIGTERM, sig_handler);
> > >
> > >         while (!done && !err) {
> > > -               if (fdarray__poll(&fda, -1)) {
> > > +               err = daemon__reconfig(daemon);
> >
> > I think it's confusing since you put the reconfig function here.
> > What not split normal and reconfig passes?
>
> hum, not sure what's confusing in here? I've been known to
> produce confusing code, but this one seems clear to me

Maybe it's because of the name.  I thought reconfig is a
special case when it detects some change.  But you call
it in the loop unconditionally.

>
> >
> > I mean something like below
> >
> >  __cmd_start()
> > {
> >     setup_server_config();
> >     daemon__run();
>
> what's daemon__run? the daemon operates in the while loop below

I thought about starting the sessions in the config.

>
> >
> >     while (!done && !err) {
> >         ...
> >         if (reconfig) {
> >             daemon__kill();
>
> you don't kill daemon for each reconfig change,
> we detect changed sessions and kill/restart only them

Yep, we can make it that way.

>
> >             setup_server_config();
> >             daemon__reconfig();
> >         }
> >     }
>
>
> so basically the current workflow is:
>
>         setup_server_config                                     <--- reads config file, prepares session objects
>
>         while (!done) {
>                 daemon__reconfig                                <--- check session objects states and run/stop them

Hmm.. then how about rename it to daemon__handle_state()
or daemon__do_loop() or something?

Thanks,
Namhyung


>
>                 if (fdarray__poll(&fda, -1)) {
>
>                         handle_config_changes(&reconfig)        <--- was there a config file change?
>
>                         if (reconfig)                           <--- yes,
>                                 setup_server_config             <---      change session objects/states
>                 }
>         }
>
> thanks,
> jirka
>