Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2631185pxb; Sat, 6 Feb 2021 02:57:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJzcQZMvWLgIk1w2EtXvv2i1pepNC2ZjIqHvhYXI37J14+ckY6AD5j7SrOKmFsCKnZlWwS+n X-Received: by 2002:aa7:d58b:: with SMTP id r11mr7834612edq.241.1612609039365; Sat, 06 Feb 2021 02:57:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612609039; cv=none; d=google.com; s=arc-20160816; b=mOW/BcD6DzHa2k+WphhVWW+wrTcivHifT/NyUOLMEos92GrYJ+4b7S8jGVFEAenU/7 jeYLMrCP6UsfymmmJ5DzZ3kg9I9d/qn+Ist4t/Yf5ctvrZ/lE4I68c3HqgJMJ2vAThpN VFjarpDQp2UFoiTr5ZcIj+uO7rkIxaARiFNtFUURYYIU2LPlMG7I36xDBTKK/RZiF/0y j/4aGpksXW7dHPRDKglF8pLIh9nLK/3XV4k5zW/CQn02tljzLea28SBzd4Gv/t2pkc36 hnrGPj+Rg/4vACKWutTN711kj/QXVU78ymtl+G6gUDpAfxnKCTeXZ0nEVnhzjznCMSzB tMUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9dwSISahcOfN3NMnONYxvA+Xvjxj9asEhl9tMU+G0iU=; b=KaMtV8JtPV+GRxQJ7vEEVWrb9E0o86QCdzALEPopd6zOtGKiaI4Kk9ihLolL502r8e G6SQEED5CmnYxXEDE8gteq1h3+TJVgZPH7n0dBF5HepSf2U5I73yeYF1saX2yq+3Ap+7 Z7cVUPSivtJSXvN1U6O7hHwTiQgTOS6PqGkMW/U8bQNaHGS6CAKtzUwp1tpOKIqPEw+6 jlVqWZT0gCYd8kKD5dz5+ojMSt2wjxBAOSHvmqAal5kSYPtWyZ7npG5H3+sRkmY6YRn/ IBlQYxYZy2p6/44JnH8IcUiSye1ME2FhsFqjqHh0SRi5QY1AnCIQa7SZ5+McvK+80IL9 k3Bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=Mo4F52hs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k5si7070849ejj.483.2021.02.06.02.56.55; Sat, 06 Feb 2021 02:57:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=Mo4F52hs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229650AbhBFKw1 (ORCPT + 99 others); Sat, 6 Feb 2021 05:52:27 -0500 Received: from mx2.suse.de ([195.135.220.15]:52944 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229772AbhBFKv3 (ORCPT ); Sat, 6 Feb 2021 05:51:29 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1612608588; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9dwSISahcOfN3NMnONYxvA+Xvjxj9asEhl9tMU+G0iU=; b=Mo4F52hs9OAJxH6oqDjd2ntDp9R6F7ZJdn+zPE4y5bLUhZ9kXSzHtT1/3GVi2DosWy+1Tx pBjsTb/LSNITlohk/amoDfpckf1C/ScW8KmaztBneh8tyVPIahPVYqgwlYXL4PiRsYG7Am RzQCI08jXlLS/z74o6/g8tAKTJ04Nz8= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DB079AEB9; Sat, 6 Feb 2021 10:49:47 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Andrew Cooper Subject: [PATCH 6/7] xen/evtch: use smp barriers for user event ring Date: Sat, 6 Feb 2021 11:49:31 +0100 Message-Id: <20210206104932.29064-7-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210206104932.29064-1-jgross@suse.com> References: <20210206104932.29064-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ring buffer for user events is used in the local system only, so smp barriers are fine for ensuring consistency. Reported-by: Andrew Cooper Signed-off-by: Juergen Gross --- drivers/xen/evtchn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c index a7a85719a8c8..421382c73d88 100644 --- a/drivers/xen/evtchn.c +++ b/drivers/xen/evtchn.c @@ -173,7 +173,7 @@ static irqreturn_t evtchn_interrupt(int irq, void *data) if ((u->ring_prod - u->ring_cons) < u->ring_size) { *evtchn_ring_entry(u, u->ring_prod) = evtchn->port; - wmb(); /* Ensure ring contents visible */ + smp_wmb(); /* Ensure ring contents visible */ if (u->ring_cons == u->ring_prod++) { wake_up_interruptible(&u->evtchn_wait); kill_fasync(&u->evtchn_async_queue, @@ -245,7 +245,7 @@ static ssize_t evtchn_read(struct file *file, char __user *buf, } rc = -EFAULT; - rmb(); /* Ensure that we see the port before we copy it. */ + smp_rmb(); /* Ensure that we see the port before we copy it. */ if (copy_to_user(buf, evtchn_ring_entry(u, c), bytes1) || ((bytes2 != 0) && copy_to_user(&buf[bytes1], &u->ring[0], bytes2))) -- 2.26.2