Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sven Schuchmann <schuchmann@schleissheimer.de>
To:     Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Pavel Machek <pavel@ucw.cz>
CC:     Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: AW: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity
 from DT
Thread-Topic: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity
 from DT
Thread-Index: AQHW+wNFjslKsenf3karGguwydAae6pIFI+AgAEq5dCAABx0AIAAifoAgAE0EVA=
Date:   Sat, 6 Feb 2021 13:14:33 +0000
Message-ID: <DB8P190MB06344FAD6492E56D28A4E916D9B19@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM>
References: <20210204143726.27977-1-schuchmann@schleissheimer.de>
 <20210204145201.GB14305@duo.ucw.cz>
 <DB8P190MB063482D8E38C0529AD16A4D5D9B29@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM>
 <20210205102338.GA27854@amd> <c107d3b9-2141-7cad-837a-f8ef107df61c@gmail.com>
In-Reply-To: <c107d3b9-2141-7cad-837a-f8ef107df61c@gmail.com>
Accept-Language: de-DE, en-US
Content-Language: de-DE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: eea10882-cde3-4085-8ce8-08d8caa1254f
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2021 13:14:33.5907
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: ba05321a-a007-44df-8805-c7e62d5887b5
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MW427SsD9GzfJlWqwJkdMhfyDAVSaE5zrwi2fYgTk6Gy0G+cNYuYpkhp90dPossBJXWX9VimK8Fq6CW11X0GdydAYzAefhC4fKdoLKOkNyM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6P190MB0086
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Dan,

> Von: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Gesendet: Freitag, 5. Februar 2021 19:37
> Hi Pavel,
>=20
> On 2/5/21 11:23 AM, Pavel Machek wrote:
> > Hi!
> >
> >>>>       patternProperties:
> >>>>         "(^led-[0-9a-f]$|led)":
> >>>> @@ -99,6 +104,7 @@ examples:
> >>>>                  reg =3D <0x1>;
> >>>>                  color =3D <LED_COLOR_ID_RGB>;
> >>>>                  function =3D LED_FUNCTION_CHARGING;
> >>>> +               default-intensity =3D <100 0 0>;
>=20
> How will you know which array position is for which child LED?
> I presume DT child nodes are not guaranteed to be parsed in the order
> of declaration?

I tried to fiddle this out, but it seems Jacek is right over here.
The multi-led definition looks like this (from the documentation leds-lp50x=
x.yaml)

        multi-led@1 {
               #address-cells =3D <1>;
               #size-cells =3D <0>;
               reg =3D <0x1>;
               color =3D <LED_COLOR_ID_RGB>;
               function =3D LED_FUNCTION_CHARGING;

               led-0 {
                   color =3D <LED_COLOR_ID_RED>;
               };

               led-1 {
                   color =3D <LED_COLOR_ID_GREEN>;
               };

               led-2 {
                   color =3D <LED_COLOR_ID_BLUE>;
               };
          };

But it seems that the color definition of each led is ignored.
By ignored I mean the driver does not take care which color
is at which position. So if I change led-0 to be LED_COLOR_ID_BLUE
and led-2 to be LED_COLOR_ID_RED nothing will change if I write
from userspace. Could you help to clarify?
Then it is even hard to know which led to set with default-intensity.

Also it seems that the enumeration of the multi-leds should
start with multi-led@0 (and not 1 as in the documentation).

Best Regards,

   Sven