Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: WVbRw2hsrwlVoNG+uz5mTDy8ErPAce6pGJmN3oEN30nM+IyUu2oVMhW7vR7U4F5GZvMTDQTw1p
 ImZfRPPWM1cqBohuV/5qe4iCVVUd8tKujg0hYvHO2wDctnmAmZ6ofWPOnfwg8a9di9cQZn/SYF
 LRu+oLfwsgR14sfv1NnwnLveUn9igq4KZVThaTqWwQoNdLXtZbRpylPWPeZC/dPkM26sE+fvOT
 jY0J51VKsD3gfUzE+d2+iYAKCXkQQq2CV0CJPIg3d+C2jGtZCzXKzKVccCaRxvxG2z8zWlxdOu
 Hvg=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <cang@codeaurora.org>,
        "daejun7.park@samsung.com" <daejun7.park@samsung.com>
CC:     Greg KH <gregkh@linuxfoundation.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "huobean@gmail.com" <huobean@gmail.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>
Subject: RE: [PATCH v19 2/3] scsi: ufs: L2P map management for HPB read
Thread-Topic: [PATCH v19 2/3] scsi: ufs: L2P map management for HPB read
Thread-Index: AQHW9f/TvOegnF+5cUGte/jMckF4fqpKxfkAgADEzjA=
Date:   Sat, 6 Feb 2021 19:17:16 +0000
Message-ID: <DM6PR04MB657586635B8B498C9E9EEDCDFCB19@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210129052848epcms2p6e5797efd94e6282b76ad9ae6c99e3ab5@epcms2p6>
 <CGME20210129052848epcms2p6e5797efd94e6282b76ad9ae6c99e3ab5@epcms2p3>
 <20210129053005epcms2p323338fbb83459d2786fc0ef92701b147@epcms2p3>
 <652fa8013c26df497049abe923eb1b97@codeaurora.org>
In-Reply-To: <652fa8013c26df497049abe923eb1b97@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 602cec8b-9c1d-4dc1-6e00-08d8cad3d120
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2021 19:17:16.6128
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AMXVW4GrfZE0edDFSv9lVS7GZA/G/06ps4MDxcCdu3c6TrwfghAvHdyc3XGQmVqDd/Wcr/5jZmUo4RBsYwkUxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5673
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +struct utp_hpb_rsp {
> > +     __be32 residual_transfer_count;
> > +     __be32 reserved1[4];
> > +     __be16 sense_data_len;
> > +     u8 desc_type;
> > +     u8 additional_len;
> > +     u8 hpb_op;
> > +     u8 reserved2;
While at it - can fix reserved2 -> lun

> > +     u8 active_rgn_cnt;
> > +     u8 inactive_rgn_cnt;
> > +     struct ufshpb_active_field hpb_active_field[2];
> > +     __be16 hpb_inactive_field[2];
> > +};

Thanks,
Avri

> > +void ufshpb_rsp_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
> > +{
> > +     struct ufshpb_lu *hpb =3D ufshpb_get_hpb_data(lrbp->cmd->device);
> > +     struct utp_hpb_rsp *rsp_field;
> > +     int data_seg_len;
> > +
> > +     if (!hpb)
> > +             return;
>=20
> You are assuming HPB recommandations only come in responses to LUs
> with HPB enabled, but the specs says the recommandations can come
> in any responses with GOOD status, meaning you should check the *hpb
> which belongs to the LUN in res_field, but not the one belongs to
> lrbp->cmd->device.
>=20
> Regards,
>=20
> Can Guo