Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210205220618.611388-1-enbyamy@gmail.com> <a3215a2b-76d3-6285-8072-160a905de362@physik.fu-berlin.de>
In-Reply-To: <a3215a2b-76d3-6285-8072-160a905de362@physik.fu-berlin.de>
From:   Amy Parker <enbyamy@gmail.com>
Date:   Sat, 6 Feb 2021 09:09:19 -0800
Message-ID: <CAE1WUT5pXOH=wjzcXBZ4YiFoVv6Xyb1sT5mxdm=NR1A1MqKgjw@mail.gmail.com>
Subject: Re: [PATCH] ia64: Fix style guide breakage
To:     John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc:     schnelle@linux.ibm.com, corbet@lwn.net, mchehab+huawei@kernel.org,
        tsbogend@alpha.franken.de, linux-ia64@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Feb 6, 2021 at 8:07 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> Hi Amy!
>
> On 2/5/21 11:06 PM, Amy Parker wrote:
> > Some statements do not have proper spacing between their C
> > keywords (commonly if and for) throughout files in the ia64 tree.
> > This patch corrects this to follow the kernel code style guide.
> >
> > Signed-off-by: Amy Parker <enbyamy@gmail.com>
>
> I never noticed. Does the kernel coding style guideline actually require
> space after "for" and "if" and similar statements but not before function
> names?

Yes it does, actually!

> So use a space after these keywords:
> if, switch, case, for, do, while

> int system_is_up(void)
> {
>         return system_state == SYSTEM_RUNNING;
> }


   -Amy IP