Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2901807pxb; Sat, 6 Feb 2021 11:37:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJx2GeWYYb6H1bHfJ05kI0e7f1gr0Y43EbSTc6cfM+ErzGtiYhOmPaqoQWUUYg+Ej11R9P/R X-Received: by 2002:a17:906:d18e:: with SMTP id c14mr10084297ejz.302.1612640267708; Sat, 06 Feb 2021 11:37:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612640267; cv=none; d=google.com; s=arc-20160816; b=F/kIA748tdJb6CBG+6MA9I0euBYqutOt7RY/enx98McxHlnIs9Egt7rFr7Kc/4WIxV 9XAkWcvg2ZoI3ziRf4KyUCi1wkbjJGKYSEV31pLEZeU+t5mrMYYhmiICKnwwIgnMUaKc TC0qmSYYyH+lC66aV/1jZeLD/x5+Nb7koTlYUM7K6+F7bqV4+elWCfajy5hCSgDPRtCn TCyo0EmAVpqjqa0FH8XCYEHJevnT+6g0NNTX7YBLjQU8JngTjqyNPfElV5L0mnf6gdeV /QtVNhoicc4ttQWQ+zv7dvX7QxZwIXSl3qqvEWsanDyDCqWLzCVqeJhdZeqycp84Of4x VLYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=xGSjaRmx2p2JR0P8vIgapMMPpiVSYCegoLT/8AClYHY=; b=MvIAoddIse1TRVSdwH+I2XOOTI4DHbPm0mb7iNaM/2R1Ty4e8ySBkcUmSpaa3m8UHn 4D1uLonZytmYerLEgKm+gMgPiysUvIaD4iSS0S2ZdPINMJqLyaClC0vaTi5Jl+u6EI2x ayIfCgjq4sP1PZu6ZGd3UwZvjo6wnrAqLCGBSEjX0YEWSdJTSA9IyjfWt95HUB/UXo6C l+2esfMjl4JNfYzVNI9fcGmZcKj6HQbSWbEXKkZadKXJk6M+lo1gWbdTH/iUFvRCH3s7 jRpONeVJYRLdQDQzNpS7vrKwE4yTnxFKt3FZQzC2hIiF/rVv6zmBlzLDxns36+LSs+df 1eDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eTmhq1wY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ka8si1145594ejc.675.2021.02.06.11.37.21; Sat, 06 Feb 2021 11:37:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eTmhq1wY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229611AbhBFTaY (ORCPT + 99 others); Sat, 6 Feb 2021 14:30:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbhBFTaV (ORCPT ); Sat, 6 Feb 2021 14:30:21 -0500 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF62AC061756; Sat, 6 Feb 2021 11:29:40 -0800 (PST) Received: by mail-pg1-x531.google.com with SMTP id m2so265999pgq.5; Sat, 06 Feb 2021 11:29:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xGSjaRmx2p2JR0P8vIgapMMPpiVSYCegoLT/8AClYHY=; b=eTmhq1wYHDxwnWkINjqlEtu842O9Rnb4Ox1dUXr7x6hCqNBx6Jqw+WMnO2U5a6DJja xFMJea3Fty0UhCrr+D/MqhyAF4rEt6sJRZBqU/JP6Xqw17ClaO/QwUbW3wiVbzj97/b3 wHXHBBYFgXdwfwNLIf5myXcMxMhyOsM6/uatRD9sqfyAsAX2ql/oSUUv7ixUnuVkjPVO JJJDtm8MGcFP6bk6lEjfsNpSKhIVwA8JgsOAj1Evhvu3NLzB2HZYAJoYy3N+zcFl6Eyx 2D4qPvGME5PJZkZ1u9dOd0wDxRzcFFPWk0orOWYc4Bg+eDBwAllBBm+aNHILje96NV00 UPFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xGSjaRmx2p2JR0P8vIgapMMPpiVSYCegoLT/8AClYHY=; b=TNKcddET+DtVw2pk/4fGMOJqVlTzYBEhhaKX5SEZ3RMDpaR9+5sjlJ+ndPh5aqSQ0S Z4HPQep6dUHAi+hg0dT6bAVGl0u5VUq1eKt/4oWWYjdFv6x2wJM27TybXbhmjHmBIRaT 2ND33QdUBA/hjpkNCzi6OE0bh7DGUomTgeHDpipbcxRuyPqTnjcOUoygF60BcNE3dNAi cqNSR2jWVdAM3tWxndJ3CkQRI2ZqyuitC3tEXzfzvAQvSNDzUjSKDJIymRJaLXC0RzFO 6rpEFbopuo8s/c5ak39ddK0PtoHPwW8WOlRho1n4RTm5wwqib8ReZzotS6t6yAZnojd2 l4cA== X-Gm-Message-State: AOAM532eQr7D5mSIF3lpLhUGRaZWm2HPXCKl+Nb4Ow9zcT0vOG+IQEpf hYxG8PA4HrzDUAmNRDc4h5ZZQltzWxqOZmst3Js= X-Received: by 2002:a63:2cc5:: with SMTP id s188mr10811983pgs.233.1612639780483; Sat, 06 Feb 2021 11:29:40 -0800 (PST) MIME-Version: 1.0 References: <20210205224124.21345-1-xie.he.0141@gmail.com> In-Reply-To: From: Xie He Date: Sat, 6 Feb 2021 11:29:29 -0800 Message-ID: Subject: Re: [PATCH net-next] net/packet: Improve the comment about LL header visibility criteria To: Eyal Birger Cc: "David S. Miller" , Jakub Kicinski , Willem de Bruijn , Eric Dumazet , John Ogness , Tanner Love , Network Development , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 6, 2021 at 7:43 AM Eyal Birger wrote: > > As such, may I suggest making this explicit by making > dev_hard_header() use dev_has_header()? That is a good idea. We may submit another patch for that.