Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932166AbWIVBMg (ORCPT ); Thu, 21 Sep 2006 21:12:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932168AbWIVBMg (ORCPT ); Thu, 21 Sep 2006 21:12:36 -0400 Received: from mail0.lsil.com ([147.145.40.20]:53903 "EHLO mail0.lsil.com") by vger.kernel.org with ESMTP id S932166AbWIVBMe convert rfc822-to-8bit (ORCPT ); Thu, 21 Sep 2006 21:12:34 -0400 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [Patch 6/7] megaraid_sas: adds tasklet for cmd completion Date: Thu, 21 Sep 2006 19:12:06 -0600 Message-ID: <0631C836DBF79F42B5A60C8C8D4E82296DF339@NAMAIL2.ad.lsil.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [Patch 6/7] megaraid_sas: adds tasklet for cmd completion Thread-Index: Acbdc4wPhb/ZXq+6QSejv6PFgS+RaQAb/w6w From: "Patro, Sumant" To: "Christoph Hellwig" Cc: , , , , , "Kolli, Neela" , "Yang, Bo" X-OriginalArrivalTime: 22 Sep 2006 01:12:07.0796 (UTC) FILETIME=[1F888340:01C6DDE4] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1118 Lines: 31 Hello Christoph, Thank you for the review of the patches. With implementation of tasklet in the driver we see a performance increase of about 8%, so we decided to go with it. Regards, Sumant -----Original Message----- From: Christoph Hellwig [mailto:hch@infradead.org] Sent: Thursday, September 21, 2006 4:46 AM To: Patro, Sumant Cc: James.Bottomley@SteelEye.com; linux-scsi@vger.kernel.org; akpm@osdl.org; hch@lst.de; linux-kernel@vger.kernel.org; Kolli, Neela; Yang, Bo Subject: Re: [Patch 6/7] megaraid_sas: adds tasklet for cmd completion On Wed, Sep 20, 2006 at 07:31:29PM -0700, Sumant Patro wrote: > This patch adds a tasklet for command completion. Why would you need this? The normal scsi command completion is offloaded to the SCSI softirq ASAP so I don't see any point for those. Do you see too much time spent in completion of the internal commands? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/