Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 7 Feb 2021 17:34:41 +1100
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc:     devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global
Message-ID: <20210207173441.2902acac@canb.auug.org.au>
In-Reply-To: <20210207000030.256592-1-memxor@gmail.com>
References: <20210207000030.256592-1-memxor@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/EFly7mjZir32_rG.96/uofl";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/EFly7mjZir32_rG.96/uofl
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Kumar,

On Sun,  7 Feb 2021 05:30:31 +0530 Kumar Kartikeya Dwivedi <memxor@gmail.co=
m> wrote:
>
> The global gpio_desc pointer and int were defined in the header,
> instead put the definitions in the translation unit and add an extern
> declaration for consumers of the header (currently only one, which is
> perhaps why the linker didn't complain about symbol collisions).
>=20
> This fixes sparse related warnings for this driver:
> drivers/staging/emxx_udc/emxx_udc.c: note: in included file:
> drivers/staging/emxx_udc/emxx_udc.h:23:18: warning: symbol 'vbus_gpio' wa=
s not declared. Should it be static?
> drivers/staging/emxx_udc/emxx_udc.h:24:5: warning: symbol 'vbus_irq' was =
not declared. Should it be static?
>=20
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>

Given that drivers/staging/emxx_udc/emxx_udc.h is only included by
drivers/staging/emxx_udc/emxx_udc.c, shouldn't these variables just be
declared static in emxx_udc.c and removed from emxx_udc.h?

> ---
>  drivers/staging/emxx_udc/emxx_udc.c | 3 +++
>  drivers/staging/emxx_udc/emxx_udc.h | 4 ++--
>  2 files changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_u=
dc/emxx_udc.c
> index a30b4f5b1..6983c3e31 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -34,6 +34,9 @@
>  #define	DRIVER_DESC	"EMXX UDC driver"
>  #define	DMA_ADDR_INVALID	(~(dma_addr_t)0)
> =20
> +struct gpio_desc *vbus_gpio;
> +int vbus_irq;
> +
>  static const char	driver_name[] =3D "emxx_udc";
>  static const char	driver_desc[] =3D DRIVER_DESC;
> =20
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_u=
dc/emxx_udc.h
> index bca614d69..b3c4ccbe5 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -20,8 +20,8 @@
>  /* below hacked up for staging integration */
>  #define GPIO_VBUS 0 /* GPIO_P153 on KZM9D */
>  #define INT_VBUS 0 /* IRQ for GPIO_P153 */
> -struct gpio_desc *vbus_gpio;
> -int vbus_irq;
> +extern struct gpio_desc *vbus_gpio;
> +extern int vbus_irq;
> =20
>  /*------------ Board dependence(Wait) */
> =20
> --=20
> 2.29.2
>=20

--=20
Cheers,
Stephen Rothwell

--Sig_/EFly7mjZir32_rG.96/uofl
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmAfigEACgkQAVBC80lX
0GzVdAf/ZuxHC/+djnJBoVnV7z59At9u7Ao6hlXOy+Omihl76+GejLqgXsUDFyAy
04/F3n6OWtDkiMZPG49RD+njyHOO2SwqHX1ENT5c+QGNS2nTFQktmZl3oNENXwzZ
HDWho0eZZllZocQL9gqbyzSO5gFlfSOM92uyhRfGonZ34KKiPKSLo7xwG0bUFpdV
arQ2ILJf4a4YHubchu8DV0e8Q7L/ji3wDZOEyu8QukCSSWo2M+yoar8gUGaFmDc5
KnHIKnhmMrP6ySYHLQHzKF4GfytLeWCZGHsPcLECpJmYxFkv6hPaTUAKo7XFW9g7
BNjJv3E6K8HoRsOpESAeOdok2KK39Q==
=fhfA
-----END PGP SIGNATURE-----

--Sig_/EFly7mjZir32_rG.96/uofl--