Date: Fri, 22 Sep 2006 11:24:27 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: kmannth@us.ibm.com
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, clameter@engr.sgi.com
Subject: Re: [BUG] i386 2.6.18 cpu_up: attempt to bring up CPU 4 failed :
 kernel BUG at mm/slab.c:2698!
Message-Id: <20060922112427.d5f3aef6.kamezawa.hiroyu@jp.fujitsu.com>
In-Reply-To: <1158888843.5657.44.camel@keithlap>
References: <1158884252.5657.38.camel@keithlap>
	<20060921174134.4e0d30f2.akpm@osdl.org>
	<1158888843.5657.44.camel@keithlap>
Organization: Fujitsu
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1227
Lines: 36

On Thu, 21 Sep 2006 18:34:03 -0700
keith mannthey <kmannth@us.ibm.com> wrote:

> That unhappy caller in the chain is cpuup_callback in mm/slab.c.  I am
> still working out as to why, there is a lot going on if this function. 
> 
> > b) pageset_cpuup_callback()'s CPU_UP_CANCELED path possibly hasn't been
> >    tested before.  I'd be guessing that we're not zeroing out the
> >    zone.pageset[] array when the `struct zone' is first allocated, but I
> >    don't immediately recall where that code lives.
> 

How about here ?
== at boot time in mm/page_alloc.c ==
free_area_init_core()
	->zone_pcp_init(zone);
        for (cpu = 0; cpu < NR_CPUS; cpu++) {
#ifdef CONFIG_NUMA
                /* Early boot. Slab allocator not functional yet */
                zone_pcp(zone, cpu) = &boot_pageset[cpu];
                setup_pageset(&boot_pageset[cpu],0);
#else
                setup_pageset(zone_pcp(zone,cpu), batch);
#endif
        }
==================

Not zero-cleared.

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/