Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3177933pxb; Sun, 7 Feb 2021 00:05:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzafE0+hpPxylzH8dCSOk7/0x3VPUqtuxl4bgVfOHT/Xtx5gBiV3erWFTLHuOK9nhE+uk9O X-Received: by 2002:a17:906:5857:: with SMTP id h23mr11400536ejs.465.1612685158899; Sun, 07 Feb 2021 00:05:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612685158; cv=none; d=google.com; s=arc-20160816; b=0u8yI7YkZ3RcHMJYukhuSltmLQkmrMUhpnlRPDA2IBoXeGAA/p4yH7lfFUo3abZy3w 4ROjXE3xud8cwFtJIDWMFPjjHh4I0ci6woPcLnvgHt4C3+fVRdidehEJeBgr0Fdx/85A 0xXSkAPvLsNxLSZG95itl0SVJ0SziIZdRM6T+c4spoRzEKBWk6FyK7uujTVo/tdPV5b4 d6fCnbrEdZow/Y0k4Rn5XDJAzlaQNJCQzJUrO4iQ6J0xw58go13zEbrPAuxgaH1rGof2 BsvVMLGqjaCwh2MA007NBkG+ufxPTFRfOC1tgf6YeR0DpEkY7mZxaoIYjCUz+HHeeRbp JSLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=g6uN8tFh8jV+4T2R1s0rRcicp7byCNuhvJh3HV5xY1I=; b=kF7U+SqrC763rFX85LhCA9oyyIoOLIzU6Rqhe1wt4i+n/B23xzUZyS+FvABM5aBQ/w 1VR2vNKU1hVMaIYY6HxKccVdSG9IcUsg8NmpLsRx2rei3WmFMZW+amMN2GpW3P0ldaBh IXxXTcSXacvX6Z8oDFk9zSKpbDITEwTZbgf8M+qkP8IGWf7UtZ0YCmEgYFj5wl5r8qwx cJ93ksE/reCSkyJ2AesWkb/IQDZs+6gGCeB/EufbhsYRnS7BL9nhlBhlxid/qkPovzv2 /1il3VRxwlj1rXsGZHax+5j/Frsn1QEmTzreqYRRhqjmV6tBr1zXkZ1lUSu3TxfwtMQB paXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gb20si2490364ejc.183.2021.02.07.00.05.35; Sun, 07 Feb 2021 00:05:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbhBGIDy (ORCPT + 99 others); Sun, 7 Feb 2021 03:03:54 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:50175 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbhBGIDw (ORCPT ); Sun, 7 Feb 2021 03:03:52 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UO3XEeI_1612684972; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UO3XEeI_1612684972) by smtp.aliyun-inc.com(127.0.0.1); Sun, 07 Feb 2021 16:02:56 +0800 From: Jiapeng Chong To: krzk@kernel.org Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Jiapeng Chong Subject: [PATCH v2] memory: tegra186-emc: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE Date: Sun, 7 Feb 2021 16:02:50 +0800 Message-Id: <1612684970-125948-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: drivers/memory/tegra/tegra186-emc.c:158:0-23: WARNING: tegra186_emc_debug_max_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE. drivers/memory/tegra/tegra186-emc.c:128:0-23: WARNING: tegra186_emc_debug_min_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- Changes in v2: - Stripped unrelated parts of the paths (./). drivers/memory/tegra/tegra186-emc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/tegra186-emc.c index fa8af17..d65e7c2 100644 --- a/drivers/memory/tegra/tegra186-emc.c +++ b/drivers/memory/tegra/tegra186-emc.c @@ -125,9 +125,9 @@ static int tegra186_emc_debug_min_rate_set(void *data, u64 rate) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(tegra186_emc_debug_min_rate_fops, - tegra186_emc_debug_min_rate_get, - tegra186_emc_debug_min_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra186_emc_debug_min_rate_fops, + tegra186_emc_debug_min_rate_get, + tegra186_emc_debug_min_rate_set, "%llu\n"); static int tegra186_emc_debug_max_rate_get(void *data, u64 *rate) { @@ -155,9 +155,9 @@ static int tegra186_emc_debug_max_rate_set(void *data, u64 rate) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(tegra186_emc_debug_max_rate_fops, - tegra186_emc_debug_max_rate_get, - tegra186_emc_debug_max_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra186_emc_debug_max_rate_fops, + tegra186_emc_debug_max_rate_get, + tegra186_emc_debug_max_rate_set, "%llu\n"); static int tegra186_emc_probe(struct platform_device *pdev) { -- 1.8.3.1