Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] Input: synaptic - reverting
 dcb00fc799dc03fd320e123e4c81b3278c763ea5 because it breaks the touchpad for
 one guy on Reddit.
From:   Hans de Goede <hdegoede@redhat.com>
To:     Colton Booth <colton@boothsoftware.ca>, dmitry.torokhov@gmail.com
Cc:     colton@boothlinux.ca, Lyude Paul <lyude@redhat.com>,
        Lee Jones <lee.jones@linaro.org>,
        Vincent Huang <vincent.huang@tw.synaptics.com>,
        Dennis Kadioglu <denk@eclipso.email>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Yussuf Khalil <dev@pp3345.net>, Ilya Katsnelson <me@0upti.me>,
        Gaurav Agrawal <agrawalgaurav@gnome.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210207035024.69095-1-colton@boothsoftware.ca>
 <08362ef4-c407-9cd0-20fa-354cd8e73fcb@redhat.com>
Message-ID: <354e080e-4ddb-9097-2ca9-4834982e925b@redhat.com>
Date:   Sun, 7 Feb 2021 11:32:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <08362ef4-c407-9cd0-20fa-354cd8e73fcb@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 2/7/21 11:18 AM, Hans de Goede wrote:
> Hi,
> 
> On 2/7/21 4:50 AM, Colton Booth wrote:
>> I can't test myself since I don't have the correct hardware, BUT this change seems to work for him. I'm thinking he has an early version of the X1E which may use slightly different trackpad revision.
> 
> Who is "him"? Do you have a bug-report link or some such ?
> 
> With which kernel version is this ?  Could it be that the commit you are reverting was
> backported to a stable-series release while that stable series is missing the rmi4
> updates necessary to make things work on newer models ?
> 
> What are the symptoms / problems "him" is seeing when not reverting this?
> 
> On case it is not clear: NACK due to insufficient information why this is
> necessary / missing description and root cause analysis of the actual problem.

p.s.

My apologies if this sounds a bit grumpy, I got out of bed on the wrong side this morning.

Regards,

Hans


> 
> Regards,
> 
> Hans
> 
> 
>>
>> Signed-off-by: Colton Booth <colton@boothsoftware.ca>
>> ---
>>  drivers/input/mouse/synaptics.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
>> index ffad142801b3..2d3f03921dbc 100644
>> --- a/drivers/input/mouse/synaptics.c
>> +++ b/drivers/input/mouse/synaptics.c
>> @@ -179,9 +179,7 @@ static const char * const smbus_pnp_ids[] = {
>>  	"LEN0093", /* T480 */
>>  	"LEN0096", /* X280 */
>>  	"LEN0097", /* X280 -> ALPS trackpoint */
>> -	"LEN0099", /* X1 Extreme Gen 1 / P1 Gen 1 */
>>  	"LEN009b", /* T580 */
>> -	"LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */
>>  	"LEN200f", /* T450s */
>>  	"LEN2044", /* L470  */
>>  	"LEN2054", /* E480 */
>>