Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3269958pxb; Sun, 7 Feb 2021 03:48:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJzwv+4/vdxG0lJ3XRopVgsIRbI64fWrXNcXpgFS9yhdVyRsuHakPijpeR7/ftOSJy59L48W X-Received: by 2002:a17:906:27d7:: with SMTP id k23mr12716962ejc.300.1612698518750; Sun, 07 Feb 2021 03:48:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612698518; cv=none; d=google.com; s=arc-20160816; b=pjN/3Wh/MlLlPKXO6TjTiw11ORGgutLw59avfRkQWUJYcaSe0hGU82UdC+uhdPQH5y EuuTRxXzYn5aSrmtrZgVG6bMnDzAK8XEzrjtljbvmHjr+yhN2Z1B0+qE3KrQMK+EIE2i 9zT/1ohnbxADtNIm90H/x3E4anO/yg1BqfKJRn4xa7+wS3gQgEVOuF9u0DAqo5PkUHBq N1as4884DXnnyaRxFJ8x4tK/8ITnsLq74PLpjouZOv6jVx0gr8KSK9iuIHNXHNhi63Ec dKE6rTcYlgsYUpsdvLQZwNkHoGwyxX3PF3k1PZIpYUKygthOSQk245HlyGEbAlGvDlvW waTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=ER/NiqPe1hmq/4EVwo+Rb8UFss0Yfr78ro17VK+3YfQ=; b=0QHgfzePDgncULBDxJTJHj13Zjr3qEbv2pSNel4yZNsAJ6jfLJl5q3g6FFKsjzO1au cERD9zbJz6dx1ULuWTKiGxWGaNoVvjaO+vbNDcE02Yu4X6rj0a13v27OvguNC45lE9W8 /vb+Om+0UiHcanBipZ+owwsHC7B4TDMcX/EvxRowm9aip0S0SRPpDT79iUGi/PsEhABm FhesXBGSb6iPYgvACwpg0Zy2f3a0aaMdEoOtVPDvvPygprUzq9FB5dXbScQK3H2leggQ Uz4I2qYUPXiV325cAt4QhOrAZTL6Eczz+a/oWc8+7RU8+GJ8yLUSsiEh/GoeOpUrT2Cd 7sKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bz20si6391645ejc.101.2021.02.07.03.48.16; Sun, 07 Feb 2021 03:48:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229832AbhBGLpf (ORCPT + 99 others); Sun, 7 Feb 2021 06:45:35 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:12451 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbhBGLkb (ORCPT ); Sun, 7 Feb 2021 06:40:31 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DYRxV1LG9zjJmC; Sun, 7 Feb 2021 19:38:38 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Sun, 7 Feb 2021 19:39:35 +0800 From: Xiaofei Tan To: , CC: , , , Xiaofei Tan Subject: [PATCH for-next 26/32] scsi: qlogicfas408: Replace spin_lock_irqsave with spin_lock in hard IRQ Date: Sun, 7 Feb 2021 19:36:57 +0800 Message-ID: <1612697823-8073-27-git-send-email-tanxiaofei@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> References: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/scsi/qlogicfas408.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qlogicfas408.c b/drivers/scsi/qlogicfas408.c index 136681a..2a70902 100644 --- a/drivers/scsi/qlogicfas408.c +++ b/drivers/scsi/qlogicfas408.c @@ -426,12 +426,11 @@ static void ql_ihandl(void *dev_id) irqreturn_t qlogicfas408_ihandl(int irq, void *dev_id) { - unsigned long flags; struct Scsi_Host *host = dev_id; - spin_lock_irqsave(host->host_lock, flags); + spin_lock(host->host_lock); ql_ihandl(dev_id); - spin_unlock_irqrestore(host->host_lock, flags); + spin_unlock(host->host_lock); return IRQ_HANDLED; } -- 2.8.1