Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3270141pxb; Sun, 7 Feb 2021 03:49:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEExIclYbTbYn8e+kidFHBmWWlBZ9/OVq0oxKut1aiFuQzKMYm8vJGM+vhJxIuQkY4VrBW X-Received: by 2002:a17:906:8690:: with SMTP id g16mr12138340ejx.113.1612698545281; Sun, 07 Feb 2021 03:49:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612698545; cv=none; d=google.com; s=arc-20160816; b=Wp8xaEgreSgTCJlhlmX+lhflKfoQynJnMquCzNxptQlI9Z22IKJT/A5TpnAgVCnuPN U+9Yyusrl2079w38nNOVGaeT/UkN/jioUYG39WjppHva/55E5gU2pxOSL/q+QIMeKEA3 X0AOEsAXG3QXsHwgaovlAl3BFVwMRljbNfFcxR282rb/8C+87JtgbocVvPUYu3ciZEd1 oVn/m2voHA3V1qRVhVCUORLoWehXgQcPROynxTDmpSQd9jgE8hkxQ+MBUuN1rpanihNO WrmxB8ikjisTTyq9nCli/zhDprVEuuIc2ffONBAE9XKn7PR3f4Iyxcnsre00CwQXyQFK XGPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=iBXnM1DNGAkSAKi6BX1q9zdX6utkIN0E8anG2280t+s=; b=WagZgaPIaUH16wQlMXk9chKsMstMhGnAvC5XV96u2SJKVMU7CBOj8Yv7MDGTByRxmi tSXnVNWXVhmUxpWx7a4iPC91ciNLqUZRiYSFrxjNvJhXmnyBjv276m50bmVQMkHISiKw Nv9sOYz8Sd4pV88ES5sdSENYp7Ykv303rWpHRnEd+Vtnl+gZ5K+CJ8xwqXYg9R1Au7fv n06D5A1bNyEI4c/D4Ei8uAZN1sc0saJgCKZb218kQaa4IAM9ZlY/styT2sKlnuHOA5iU AdnCbgPwDxSf0Xf31C4q8ywUODGfbGeCeAYe/wvu0PfIrLaYBZVnrrG+hCb9MAf/rXTO Re0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r21si10561591ejo.142.2021.02.07.03.48.41; Sun, 07 Feb 2021 03:49:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbhBGLsJ (ORCPT + 99 others); Sun, 7 Feb 2021 06:48:09 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:12090 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbhBGLlG (ORCPT ); Sun, 7 Feb 2021 06:41:06 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DYRwg5JfSzMWS4; Sun, 7 Feb 2021 19:37:55 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Sun, 7 Feb 2021 19:39:31 +0800 From: Xiaofei Tan To: , CC: , , , Xiaofei Tan Subject: [PATCH for-next 15/32] scsi: initio: Replace spin_lock_irqsave with spin_lock in hard IRQ Date: Sun, 7 Feb 2021 19:36:46 +0800 Message-ID: <1612697823-8073-16-git-send-email-tanxiaofei@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> References: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/scsi/initio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c index 814acc5..3fafa8f 100644 --- a/drivers/scsi/initio.c +++ b/drivers/scsi/initio.c @@ -2507,12 +2507,11 @@ static int initio_wait_done_disc(struct initio_host * host) static irqreturn_t i91u_intr(int irqno, void *dev_id) { struct Scsi_Host *dev = dev_id; - unsigned long flags; int r; - spin_lock_irqsave(dev->host_lock, flags); + spin_lock(dev->host_lock); r = initio_isr((struct initio_host *)dev->hostdata); - spin_unlock_irqrestore(dev->host_lock, flags); + spin_unlock(dev->host_lock); if (r) return IRQ_HANDLED; else -- 2.8.1